* [PATCH] ftrace: use non-archaic spelling of failes
@ 2018-05-31 12:17 Thadeu Lima de Souza Cascardo
2018-05-31 15:15 ` Joe Perches
2018-05-31 22:46 ` Steven Rostedt
0 siblings, 2 replies; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2018-05-31 12:17 UTC (permalink / raw)
To: linux-kernel; +Cc: rostedt, mingo
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
kernel/trace/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 8d83bcf9ef69..b218cee1f18c 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
* @reset - non zero to reset all filters before applying this filter.
*
* Filters denote which functions should be enabled when tracing is enabled
- * If @ip is NULL, it failes to update filter.
+ * If @ip is NULL, it fails to update filter.
*/
int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
int remove, int reset)
--
2.17.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftrace: use non-archaic spelling of failes
2018-05-31 12:17 [PATCH] ftrace: use non-archaic spelling of failes Thadeu Lima de Souza Cascardo
@ 2018-05-31 15:15 ` Joe Perches
2018-05-31 15:16 ` Thadeu Lima de Souza Cascardo
2018-05-31 22:46 ` Steven Rostedt
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2018-05-31 15:15 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo, linux-kernel; +Cc: rostedt, mingo
On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
[]
> @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> * @reset - non zero to reset all filters before applying this filter.
> *
> * Filters denote which functions should be enabled when tracing is enabled
> - * If @ip is NULL, it failes to update filter.
> + * If @ip is NULL, it fails to update filter.
> */
> int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> int remove, int reset)
Perhaps fix it treewide?
$ git grep -w -i failes | wc -l
8
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftrace: use non-archaic spelling of failes
2018-05-31 15:15 ` Joe Perches
@ 2018-05-31 15:16 ` Thadeu Lima de Souza Cascardo
2018-05-31 15:20 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2018-05-31 15:16 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, rostedt, mingo
On Thu, May 31, 2018 at 08:15:45AM -0700, Joe Perches wrote:
> On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> []
> > @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> > * @reset - non zero to reset all filters before applying this filter.
> > *
> > * Filters denote which functions should be enabled when tracing is enabled
> > - * If @ip is NULL, it failes to update filter.
> > + * If @ip is NULL, it fails to update filter.
> > */
> > int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> > int remove, int reset)
>
> Perhaps fix it treewide?
>
> $ git grep -w -i failes | wc -l
> 8
>
I sent patches to the respective maintainers for all of these.
Cascardo.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftrace: use non-archaic spelling of failes
2018-05-31 15:16 ` Thadeu Lima de Souza Cascardo
@ 2018-05-31 15:20 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2018-05-31 15:20 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo; +Cc: linux-kernel, rostedt, mingo
On Thu, 2018-05-31 at 12:16 -0300, Thadeu Lima de Souza Cascardo wrote:
> On Thu, May 31, 2018 at 08:15:45AM -0700, Joe Perches wrote:
> > On Thu, 2018-05-31 at 09:17 -0300, Thadeu Lima de Souza Cascardo wrote:
> > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > []
> > > @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> > > * @reset - non zero to reset all filters before applying this filter.
> > > *
> > > * Filters denote which functions should be enabled when tracing is enabled
> > > - * If @ip is NULL, it failes to update filter.
> > > + * If @ip is NULL, it fails to update filter.
> > > */
> > > int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> > > int remove, int reset)
> >
> > Perhaps fix it treewide?
> >
> > $ git grep -w -i failes | wc -l
> > 8
>
> I sent patches to the respective maintainers for all of these.
Great, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ftrace: use non-archaic spelling of failes
2018-05-31 12:17 [PATCH] ftrace: use non-archaic spelling of failes Thadeu Lima de Souza Cascardo
2018-05-31 15:15 ` Joe Perches
@ 2018-05-31 22:46 ` Steven Rostedt
1 sibling, 0 replies; 5+ messages in thread
From: Steven Rostedt @ 2018-05-31 22:46 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo; +Cc: linux-kernel, mingo, trivial
On Thu, 31 May 2018 09:17:01 -0300
Thadeu Lima de Souza Cascardo <cascardo@canonical.com> wrote:
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 8d83bcf9ef69..b218cee1f18c 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4788,7 +4788,7 @@ ftrace_set_addr(struct ftrace_ops *ops, unsigned long ip, int remove,
> * @reset - non zero to reset all filters before applying this filter.
> *
> * Filters denote which functions should be enabled when tracing is enabled
> - * If @ip is NULL, it failes to update filter.
> + * If @ip is NULL, it fails to update filter.
> */
> int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> int remove, int reset)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-31 22:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31 12:17 [PATCH] ftrace: use non-archaic spelling of failes Thadeu Lima de Souza Cascardo
2018-05-31 15:15 ` Joe Perches
2018-05-31 15:16 ` Thadeu Lima de Souza Cascardo
2018-05-31 15:20 ` Joe Perches
2018-05-31 22:46 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®