mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sankalp Negi <sankalpnegi2310@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	NeilBrown <neil@brown.name>,
	Sankalp Negi <sankalpnegi2310@gmail.com>
Subject: [PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl.
Date: Fri, 1 Jun 2018 00:25:43 +0530	[thread overview]
Message-ID: <20180531185542.phhu2rkdoq2czkav@localhost> (raw)

This patch fixes following checkpatch.pl issues:

WARNING : line over 80 characters
ERROR   : code indent should use tabs where possible
WARNING : no spaces at the start of a line
ERROR   : switch and case should be at the same indent
ERROR   : space required before the open parenthesis
WARNING : braces {} are not necessary for single statement blocks

Signed-off-by: Sankalp Negi <sankalpnegi2310@gmail.com>
---
 drivers/staging/mt7621-spi/spi-mt7621.c | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c
index 37f299080410..cd94f5f569df 100644
--- a/drivers/staging/mt7621-spi/spi-mt7621.c
+++ b/drivers/staging/mt7621-spi/spi-mt7621.c
@@ -55,7 +55,8 @@
 #define MT7621_CPOL		BIT(4)
 #define MT7621_LSB_FIRST	BIT(3)
 
-#define RT2880_SPI_MODE_BITS	(SPI_CPOL | SPI_CPHA | SPI_LSB_FIRST | SPI_CS_HIGH)
+#define RT2880_SPI_MODE_BITS	(SPI_CPOL | SPI_CPHA |		\
+				SPI_LSB_FIRST | SPI_CS_HIGH)
 
 struct mt7621_spi;
 
@@ -104,7 +105,7 @@ static void mt7621_spi_set_cs(struct spi_device *spi, int enable)
 	int cs = spi->chip_select;
 	u32 polar = 0;
 
-        mt7621_spi_reset(rs, cs);
+	mt7621_spi_reset(rs, cs);
 	if (enable)
 		polar = BIT(cs);
 	mt7621_spi_write(rs, MT7621_SPI_POLAR, polar);
@@ -137,18 +138,18 @@ static int mt7621_spi_prepare(struct spi_device *spi, unsigned int speed)
 		reg |= MT7621_LSB_FIRST;
 
 	reg &= ~(MT7621_CPHA | MT7621_CPOL);
-	switch(spi->mode & (SPI_CPOL | SPI_CPHA)) {
-		case SPI_MODE_0:
-			break;
-		case SPI_MODE_1:
-			reg |= MT7621_CPHA;
-			break;
-		case SPI_MODE_2:
-			reg |= MT7621_CPOL;
-			break;
-		case SPI_MODE_3:
-			reg |= MT7621_CPOL | MT7621_CPHA;
-			break;
+	switch (spi->mode & (SPI_CPOL | SPI_CPHA)) {
+	case SPI_MODE_0:
+		break;
+	case SPI_MODE_1:
+		reg |= MT7621_CPHA;
+		break;
+	case SPI_MODE_2:
+		reg |= MT7621_CPOL;
+		break;
+	case SPI_MODE_3:
+		reg |= MT7621_CPOL | MT7621_CPHA;
+		break;
 	}
 	mt7621_spi_write(rs, MT7621_SPI_MASTER, reg);
 
@@ -164,9 +165,8 @@ static inline int mt7621_spi_wait_till_ready(struct spi_device *spi)
 		u32 status;
 
 		status = mt7621_spi_read(rs, MT7621_SPI_TRANS);
-		if ((status & SPITRANS_BUSY) == 0) {
+		if ((status & SPITRANS_BUSY) == 0)
 			return 0;
-		}
 		cpu_relax();
 		udelay(1);
 	}
-- 
2.11.0

             reply	other threads:[~2018-05-31 18:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 18:55 Sankalp Negi [this message]
2018-05-31 21:03 ` NeilBrown
2018-05-31 22:14 ` Joe Perches
2018-06-01  9:15 ` Greg Kroah-Hartman
2018-06-02 14:26   ` [PATCH v2 0/5] staging: mt7621-spi: Fix Coding style issues Sankalp Negi
2018-06-02 14:26     ` [PATCH v2 1/5] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl Sankalp Negi
2018-06-02 14:26     ` [PATCH v2 2/5] " Sankalp Negi
2018-06-02 14:26     ` [PATCH v2 3/5] " Sankalp Negi
2018-06-02 14:26     ` [PATCH v2 4/5] " Sankalp Negi
2018-06-02 14:26     ` [PATCH v2 5/5] " Sankalp Negi
2018-06-02 15:27     ` [PATCH v2 0/5] staging: mt7621-spi: Fix Coding style issues Joe Perches
2018-06-02 18:37       ` [PATCH v3 0/5] staging: mt7621-spi: Fix C " Sankalp Negi
2018-06-02 18:37         ` [PATCH v3 1/5] staging: mt7621-spi: Indent case labels and switch at the same level Sankalp Negi
2018-06-02 18:37         ` [PATCH v3 2/5] staging: mt7621-spi: Fix line over 80 characters by refactoring Sankalp Negi
2018-06-02 18:37         ` [PATCH v3 3/5] staging: mt7621-spi: Use tabs for indentation instead of spaces Sankalp Negi
2018-06-02 18:37         ` [PATCH v3 4/5] staging: mt7621-spi: Add a space before open paranthesis Sankalp Negi
2018-06-02 18:37         ` [PATCH v3 5/5] staging: mt7621-spi: Remove unnecessary braces {} from single statement if block Sankalp Negi
2018-06-04  0:18         ` [PATCH v3 0/5] staging: mt7621-spi: Fix C Coding style issues NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531185542.phhu2rkdoq2czkav@localhost \
    --to=sankalpnegi2310@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil@brown.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome