From: Joe Perches <joe@perches.com>
To: Sankalp Negi <sankalpnegi2310@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
NeilBrown <neil@brown.name>
Subject: Re: [PATCH] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl.
Date: Thu, 31 May 2018 15:14:43 -0700 [thread overview]
Message-ID: <f6df017094f9ebaa13e552a11584d33971f04b0f.camel@perches.com> (raw)
In-Reply-To: <20180531185542.phhu2rkdoq2czkav@localhost>
On Fri, 2018-06-01 at 00:25 +0530, Sankalp Negi wrote:
> diff --git a/drivers/staging/mt7621-spi/spi-mt7621.c b/drivers/staging/mt7621-spi/spi-mt7621.c
[]
> @@ -164,9 +165,8 @@ static inline int mt7621_spi_wait_till_ready(struct spi_device *spi)
> u32 status;
>
> status = mt7621_spi_read(rs, MT7621_SPI_TRANS);
> - if ((status & SPITRANS_BUSY) == 0) {
> + if ((status & SPITRANS_BUSY) == 0)
> return 0;
> - }
> cpu_relax();
> udelay(1);
> }
It might also be more readable to avoid a status temporary
and use a direct compare instead:
for (i = 0; i < RALINK_SPI_WAIT_MAX_LOOP; i++) {
if (!(mt7621_spi_read(rs, MT7621_SPI_TRANS) & SPITRANS_BUSY))
return 0;
cpu_relax();
udelay(1);
}
return -ETIMEDOUT;
}
next prev parent reply other threads:[~2018-05-31 22:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 18:55 Sankalp Negi
2018-05-31 21:03 ` NeilBrown
2018-05-31 22:14 ` Joe Perches [this message]
2018-06-01 9:15 ` Greg Kroah-Hartman
2018-06-02 14:26 ` [PATCH v2 0/5] staging: mt7621-spi: Fix Coding style issues Sankalp Negi
2018-06-02 14:26 ` [PATCH v2 1/5] staging: mt7621-spi: Fix Coding style issues reported by checkpatch.pl Sankalp Negi
2018-06-02 14:26 ` [PATCH v2 2/5] " Sankalp Negi
2018-06-02 14:26 ` [PATCH v2 3/5] " Sankalp Negi
2018-06-02 14:26 ` [PATCH v2 4/5] " Sankalp Negi
2018-06-02 14:26 ` [PATCH v2 5/5] " Sankalp Negi
2018-06-02 15:27 ` [PATCH v2 0/5] staging: mt7621-spi: Fix Coding style issues Joe Perches
2018-06-02 18:37 ` [PATCH v3 0/5] staging: mt7621-spi: Fix C " Sankalp Negi
2018-06-02 18:37 ` [PATCH v3 1/5] staging: mt7621-spi: Indent case labels and switch at the same level Sankalp Negi
2018-06-02 18:37 ` [PATCH v3 2/5] staging: mt7621-spi: Fix line over 80 characters by refactoring Sankalp Negi
2018-06-02 18:37 ` [PATCH v3 3/5] staging: mt7621-spi: Use tabs for indentation instead of spaces Sankalp Negi
2018-06-02 18:37 ` [PATCH v3 4/5] staging: mt7621-spi: Add a space before open paranthesis Sankalp Negi
2018-06-02 18:37 ` [PATCH v3 5/5] staging: mt7621-spi: Remove unnecessary braces {} from single statement if block Sankalp Negi
2018-06-04 0:18 ` [PATCH v3 0/5] staging: mt7621-spi: Fix C Coding style issues NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6df017094f9ebaa13e552a11584d33971f04b0f.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
--cc=sankalpnegi2310@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®