* [PATCH] coresight: include vmalloc.h for vmap/vunmap
@ 2018-06-05 11:48 Arnd Bergmann
2018-06-05 16:06 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-06-05 11:48 UTC (permalink / raw)
To: Mathieu Poirier, Alexander Shishkin
Cc: Arnd Bergmann, Suzuki K Poulose, Greg Kroah-Hartman,
linux-arm-kernel, linux-kernel
The newly introduced code fails to build in some configurations
unless we include the right headers:
drivers/hwtracing/coresight/coresight-tmc-etr.c: In function 'tmc_free_table_pages':
drivers/hwtracing/coresight/coresight-tmc-etr.c:206:3: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration]
Fixes: 79613ae8715a ("coresight: Add generic TMC sg table framework")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
index 6164eed0b5fe..3556d9a849e9 100644
--- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
+++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
@@ -8,6 +8,7 @@
#include <linux/dma-mapping.h>
#include <linux/iommu.h>
#include <linux/slab.h>
+#include <linux/vmalloc.h>
#include "coresight-priv.h"
#include "coresight-tmc.h"
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] coresight: include vmalloc.h for vmap/vunmap
2018-06-05 11:48 [PATCH] coresight: include vmalloc.h for vmap/vunmap Arnd Bergmann
@ 2018-06-05 16:06 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2018-06-05 16:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Alexander Shishkin, Suzuki K Poulose, Greg Kroah-Hartman,
linux-arm-kernel, Linux Kernel Mailing List
On 5 June 2018 at 05:48, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly introduced code fails to build in some configurations
> unless we include the right headers:
>
> drivers/hwtracing/coresight/coresight-tmc-etr.c: In function 'tmc_free_table_pages':
> drivers/hwtracing/coresight/coresight-tmc-etr.c:206:3: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration]
>
> Fixes: 79613ae8715a ("coresight: Add generic TMC sg table framework")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/hwtracing/coresight/coresight-tmc-etr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> index 6164eed0b5fe..3556d9a849e9 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
> @@ -8,6 +8,7 @@
> #include <linux/dma-mapping.h>
> #include <linux/iommu.h>
> #include <linux/slab.h>
> +#include <linux/vmalloc.h>
> #include "coresight-priv.h"
> #include "coresight-tmc.h"
>
Thank you for that - I have picked it up for 4.18-rc1.
Mathieu
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-05 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 11:48 [PATCH] coresight: include vmalloc.h for vmap/vunmap Arnd Bergmann
2018-06-05 16:06 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®