From: Alex Williamson <alex.williamson@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples: mbochs: add DMA_SHARED_BUFFER dependency
Date: Sat, 9 Jun 2018 09:29:37 -0600 [thread overview]
Message-ID: <20180609092937.1c317550@w520.home> (raw)
In-Reply-To: <20180530213801.731288-1-arnd@arndb.de>
On Wed, 30 May 2018 23:37:31 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is
> disabled:
>
> ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined!
> ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined!
>
> This uses a 'select' statement to enable that framework, like all
> other users do.
>
> Fixes: 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> samples/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 3aeaaca77831..bd133efc1a56 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
> config SAMPLE_VFIO_MDEV_MBOCHS
> tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> depends on VFIO_MDEV_DEVICE && m
> + select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It supports the region display interface
Almost missed this one. Applied to my next branch for v4.18, also
updated the referenced commit ID as I've had to rebase to account for
a reverted patch in the base. Thanks,
Alex
prev parent reply other threads:[~2018-06-09 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 21:37 Arnd Bergmann
2018-06-09 15:29 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609092937.1c317550@w520.home \
--to=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=joe.lawrence@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®