* [PATCH] samples: mbochs: add DMA_SHARED_BUFFER dependency
@ 2018-05-30 21:37 Arnd Bergmann
2018-06-09 15:29 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-05-30 21:37 UTC (permalink / raw)
To: Gerd Hoffmann, Alex Williamson; +Cc: Arnd Bergmann, Joe Lawrence, linux-kernel
The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is
disabled:
ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined!
ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined!
This uses a 'select' statement to enable that framework, like all
other users do.
Fixes: 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
samples/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/samples/Kconfig b/samples/Kconfig
index 3aeaaca77831..bd133efc1a56 100644
--- a/samples/Kconfig
+++ b/samples/Kconfig
@@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
config SAMPLE_VFIO_MDEV_MBOCHS
tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
depends on VFIO_MDEV_DEVICE && m
+ select DMA_SHARED_BUFFER
help
Build a virtual display sample driver for use as a VFIO
mediated device. It supports the region display interface
--
2.9.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] samples: mbochs: add DMA_SHARED_BUFFER dependency
2018-05-30 21:37 [PATCH] samples: mbochs: add DMA_SHARED_BUFFER dependency Arnd Bergmann
@ 2018-06-09 15:29 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2018-06-09 15:29 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Gerd Hoffmann, Joe Lawrence, linux-kernel
On Wed, 30 May 2018 23:37:31 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> The new bochs vbe sample fails to link when DMA_SHARED_BUFFER is
> disabled:
>
> ERROR: "dma_buf_export" [samples/vfio-mdev/mbochs.ko] undefined!
> ERROR: "dma_buf_fd" [samples/vfio-mdev/mbochs.ko] undefined!
>
> This uses a 'select' statement to enable that framework, like all
> other users do.
>
> Fixes: 8021194eb3da ("sample: vfio bochs vbe display (host device for bochs-drm)")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> samples/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/Kconfig b/samples/Kconfig
> index 3aeaaca77831..bd133efc1a56 100644
> --- a/samples/Kconfig
> +++ b/samples/Kconfig
> @@ -135,6 +135,7 @@ config SAMPLE_VFIO_MDEV_MDPY_FB
> config SAMPLE_VFIO_MDEV_MBOCHS
> tristate "Build VFIO mdpy example mediated device sample code -- loadable modules only"
> depends on VFIO_MDEV_DEVICE && m
> + select DMA_SHARED_BUFFER
> help
> Build a virtual display sample driver for use as a VFIO
> mediated device. It supports the region display interface
Almost missed this one. Applied to my next branch for v4.18, also
updated the referenced commit ID as I've had to rebase to account for
a reverted patch in the base. Thanks,
Alex
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-09 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-30 21:37 [PATCH] samples: mbochs: add DMA_SHARED_BUFFER dependency Arnd Bergmann
2018-06-09 15:29 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®