From: Peter Zijlstra <peterz@infradead.org>
To: Jeremy Cline <jeremy@jcline.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
rui.zhang@intel.com, len.brown@intel.com, stable@vger.kernel.org,
linux-kernel@vger.kernel.org, regressions@leemhuis.info,
Diego Viola <diego.viola@gmail.com>
Subject: Re: Regression: x86/tsc: Fix mark_tsc_unstable()
Date: Mon, 11 Jun 2018 16:38:01 +0200 [thread overview]
Message-ID: <20180611143801.GH12235@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180611141742.GP12198@hirez.programming.kicks-ass.net>
On Mon, Jun 11, 2018 at 04:17:42PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 11, 2018 at 01:59:15PM +0000, Jeremy Cline wrote:
> > A user has bisected the problem to the v4.16 commit 1ab4ca7c59d4
> > ("x86/tsc: Fix mark_tsc_unstable()"). According to the reporter,
> > explicitly setting "tsc=" on the kernel command line causes the boot to
> > always succeed. All the users have Thinkpad T500s or T400s (Core 2 Duos)
>
> Weird. So Core2 typically triggers mark_tsc_unstable() in either
> intel_idle or processor_idle. ISTR testing that when I did the patches.
>
> When I make that mark_tsc_unstable() in the idle drivers unconditional
> and boot my ivb with that, it doesn't want to fail. I've booted the
> machine 5 consequctive times without issue.
>
> Let me try and checkout -stable, maybe something's up with that.
Nope -stable seems to be working as well on the IVB (with modification).
I just dug up my T500 and that's actually still running the test kernel.
Let me try and build the -stable kernel for that.
next prev parent reply other threads:[~2018-06-11 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 13:59 Jeremy Cline
2018-06-11 14:17 ` Peter Zijlstra
2018-06-11 14:38 ` Peter Zijlstra [this message]
2018-06-11 15:30 ` Peter Zijlstra
2018-06-11 17:56 ` Jeremy Cline
2018-06-11 18:11 ` Jeremy Cline
2018-06-11 19:23 ` Diego Viola
2018-06-11 21:31 ` Jeremy Cline
2018-06-11 17:47 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611143801.GH12235@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=diego.viola@gmail.com \
--cc=jeremy@jcline.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=regressions@leemhuis.info \
--cc=rui.zhang@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®