[BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Jia-Ju Bai]

The kernel may sleep with holding a spinlock.
The function call path (from bottom to top) in Linux-4.16.7 is:

[FUNC] vfree --> can sleep
kernel/kcov.c, 237: vfree in kcov_put
kernel/kcov.c, 396: kcov_put in kcov_ioctl_locked
kernel/kcov.c, 410: kcov_ioctl_locked in kcov_ioctl
kernel/kcov.c, 409: spin_lock in kcov_ioctl

This bug is found by my static analysis tool (DSAC-2) and checked by my
code review.

I do not know how to correctly fix this bug, so I just report them.


Best wishes,
Jia-Ju Bai

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Al Viro]

On Thu, Jun 21, 2018 at 11:20:59AM +0800, Jia-Ju Bai wrote:
> The kernel may sleep with holding a spinlock.
> The function call path (from bottom to top) in Linux-4.16.7 is:
> 
> [FUNC] vfree --> can sleep
> kernel/kcov.c, 237: vfree in kcov_put
> kernel/kcov.c, 396: kcov_put in kcov_ioctl_locked
> kernel/kcov.c, 410: kcov_ioctl_locked in kcov_ioctl
> kernel/kcov.c, 409: spin_lock in kcov_ioctl
> 
> This bug is found by my static analysis tool (DSAC-2) and checked by my
> code review.
> 
> I do not know how to correctly fix this bug, so I just report them.

Assuming it's a bug in the first place, that is.  Note that
	* we never modify task->kcov for task != current
	* task->kcov contributes to refcount
	* opened file contributes to refcount
	* that kcov_put() of yours happens from ->ioctl() and removes
current->kcov reference; it *can't* be the last reference - the one
held by struct file used to call ->ioctl() is also there.

IOW, it's a false positive.

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Jia-Ju Bai]

On 2018/6/21 11:43, Al Viro wrote:
> On Thu, Jun 21, 2018 at 11:20:59AM +0800, Jia-Ju Bai wrote:
>> The kernel may sleep with holding a spinlock.
>> The function call path (from bottom to top) in Linux-4.16.7 is:
>>
>> [FUNC] vfree --> can sleep
>> kernel/kcov.c, 237: vfree in kcov_put
>> kernel/kcov.c, 396: kcov_put in kcov_ioctl_locked
>> kernel/kcov.c, 410: kcov_ioctl_locked in kcov_ioctl
>> kernel/kcov.c, 409: spin_lock in kcov_ioctl
>>
>> This bug is found by my static analysis tool (DSAC-2) and checked by my
>> code review.
>>
>> I do not know how to correctly fix this bug, so I just report them.
> Assuming it's a bug in the first place, that is.  Note that
> 	* we never modify task->kcov for task != current
> 	* task->kcov contributes to refcount
> 	* opened file contributes to refcount
> 	* that kcov_put() of yours happens from ->ioctl() and removes
> current->kcov reference; it *can't* be the last reference - the one
> held by struct file used to call ->ioctl() is also there.
>
> IOW, it's a false positive.

Okay, thanks for your reply and explanation.
I agree that my report is false.


Best wishes,
Jia-Ju Bai

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Jia-Ju Bai]

On 2019/12/17 21:13, Dmitry Vyukov wrote:
> On Tue, Dec 17, 2019 at 2:11 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>> On 2019/12/17 21:02, Dmitry Vyukov wrote:
>>> On Tue, Dec 17, 2019 at 1:56 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>>>> The kernel may sleep while holding a spinlock.
>>>> The function call path (from bottom to top) in Linux 4.19 is:
>>>>
>>>> kernel/kcov.c, 237:
>>>>        vfree in kcov_put
>>>> kernel/kcov.c, 413:
>>>>        kcov_put in kcov_ioctl_locked
>>>> kernel/kcov.c, 427:
>>>>        kcov_ioctl_locked in kcov_ioctl
>>>> kernel/kcov.c, 426:
>>>>        spin_lock in kcov_ioctl
>>>>
>>>> vfree() can sleep at runtime.
>>>>
>>>> I am not sure how to properly fix this possible bug, so I only report it.
>>>> A possible way is to replace vfree() with kfree(), and replace related
>>>> calls to vmalloc() with kmalloc().
>>>>
>>>> This bug is found by a static analysis tool STCheck written by myself.
>>> Hi Jia-Ju,
>>>
>>> Are you sure kcov_ioctl_locked can really release the descriptor? It
>>> happens in the context of ioctl, which means there is an open
>>> reference for the file descriptor. So ioctl should not do vfree I
>>> would assume.
>> Thanks for the reply :)
>> I am not sure, because I am not familiar with kcov.
>> But looking at the code, if the reference count of kcov is 1, vfree()
>> could be called.
> That kcov_put should never call vfree. We still hold reference
> associated with the file, which will be released in kcov_close.

Okay, thanks for the explanation :)
My static analysis tool does not know this fact, so it reports the false 
bug, sorry...


Best wishes,
Jia-Ju Bai

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Dmitry Vyukov]

On Tue, Dec 17, 2019 at 2:11 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> On 2019/12/17 21:02, Dmitry Vyukov wrote:
> > On Tue, Dec 17, 2019 at 1:56 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
> >> The kernel may sleep while holding a spinlock.
> >> The function call path (from bottom to top) in Linux 4.19 is:
> >>
> >> kernel/kcov.c, 237:
> >>       vfree in kcov_put
> >> kernel/kcov.c, 413:
> >>       kcov_put in kcov_ioctl_locked
> >> kernel/kcov.c, 427:
> >>       kcov_ioctl_locked in kcov_ioctl
> >> kernel/kcov.c, 426:
> >>       spin_lock in kcov_ioctl
> >>
> >> vfree() can sleep at runtime.
> >>
> >> I am not sure how to properly fix this possible bug, so I only report it.
> >> A possible way is to replace vfree() with kfree(), and replace related
> >> calls to vmalloc() with kmalloc().
> >>
> >> This bug is found by a static analysis tool STCheck written by myself.
> > Hi Jia-Ju,
> >
> > Are you sure kcov_ioctl_locked can really release the descriptor? It
> > happens in the context of ioctl, which means there is an open
> > reference for the file descriptor. So ioctl should not do vfree I
> > would assume.
>
> Thanks for the reply :)
> I am not sure, because I am not familiar with kcov.
> But looking at the code, if the reference count of kcov is 1, vfree()
> could be called.

That kcov_put should never call vfree. We still hold reference
associated with the file, which will be released in kcov_close.

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Jia-Ju Bai]

On 2019/12/17 21:02, Dmitry Vyukov wrote:
> On Tue, Dec 17, 2019 at 1:56 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>> The kernel may sleep while holding a spinlock.
>> The function call path (from bottom to top) in Linux 4.19 is:
>>
>> kernel/kcov.c, 237:
>>       vfree in kcov_put
>> kernel/kcov.c, 413:
>>       kcov_put in kcov_ioctl_locked
>> kernel/kcov.c, 427:
>>       kcov_ioctl_locked in kcov_ioctl
>> kernel/kcov.c, 426:
>>       spin_lock in kcov_ioctl
>>
>> vfree() can sleep at runtime.
>>
>> I am not sure how to properly fix this possible bug, so I only report it.
>> A possible way is to replace vfree() with kfree(), and replace related
>> calls to vmalloc() with kmalloc().
>>
>> This bug is found by a static analysis tool STCheck written by myself.
> Hi Jia-Ju,
>
> Are you sure kcov_ioctl_locked can really release the descriptor? It
> happens in the context of ioctl, which means there is an open
> reference for the file descriptor. So ioctl should not do vfree I
> would assume.

Thanks for the reply :)
I am not sure, because I am not familiar with kcov.
But looking at the code, if the reference count of kcov is 1, vfree() 
could be called.


Best wishes,
Jia-Ju Bai

Re: [BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Dmitry Vyukov]

On Tue, Dec 17, 2019 at 1:56 PM Jia-Ju Bai <baijiaju1990@gmail.com> wrote:
>
> The kernel may sleep while holding a spinlock.
> The function call path (from bottom to top) in Linux 4.19 is:
>
> kernel/kcov.c, 237:
>      vfree in kcov_put
> kernel/kcov.c, 413:
>      kcov_put in kcov_ioctl_locked
> kernel/kcov.c, 427:
>      kcov_ioctl_locked in kcov_ioctl
> kernel/kcov.c, 426:
>      spin_lock in kcov_ioctl
>
> vfree() can sleep at runtime.
>
> I am not sure how to properly fix this possible bug, so I only report it.
> A possible way is to replace vfree() with kfree(), and replace related
> calls to vmalloc() with kmalloc().
>
> This bug is found by a static analysis tool STCheck written by myself.

Hi Jia-Ju,

Are you sure kcov_ioctl_locked can really release the descriptor? It
happens in the context of ioctl, which means there is an open
reference for the file descriptor. So ioctl should not do vfree I
would assume.

[BUG] kernel: kcov: a possible sleep-in-atomic-context bug in kcov_ioctl()

[Jia-Ju Bai]

The kernel may sleep while holding a spinlock.
The function call path (from bottom to top) in Linux 4.19 is:

kernel/kcov.c, 237:
     vfree in kcov_put
kernel/kcov.c, 413:
     kcov_put in kcov_ioctl_locked
kernel/kcov.c, 427:
     kcov_ioctl_locked in kcov_ioctl
kernel/kcov.c, 426:
     spin_lock in kcov_ioctl

vfree() can sleep at runtime.

I am not sure how to properly fix this possible bug, so I only report it.
A possible way is to replace vfree() with kfree(), and replace related 
calls to vmalloc() with kmalloc().

This bug is found by a static analysis tool STCheck written by myself.


Best wishes,
Jia-Ju Bai