* [PATCH] x86/xen: add call of speculative_store_bypass_ht_init() to pv paths
@ 2018-06-21 8:43 Juergen Gross
2018-06-21 13:01 ` Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2018-06-21 8:43 UTC (permalink / raw)
To: linux-kernel, xen-devel, x86
Cc: boris.ostrovsky, hpa, tglx, mingo, Juergen Gross, stable
Commit 1f50ddb4f4189243c05926b842dc1a0332195f31 ("x86/speculation:
Handle HT correctly on AMD") added speculative_store_bypass_ht_init()
to the per-cpu initialization sequence.
speculative_store_bypass_ht_init() needs to be called on each cpu for
pv guests, too.
Reported-by: Brian Woods <brian.woods@amd.com>
Fixes: 1f50ddb4f4189243c05926b842dc1a0332195f31 ("x86/speculation: Handle HT correctly on AMD")
Cc: <stable@vger.kernel.org>
Signed-off-by: Juergen Gross <jgross@suse.com>
Tested-by: Brian Woods <brian.woods@amd.com>
---
arch/x86/xen/smp_pv.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 2e20ae2fa2d6..e3b18ad49889 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -32,6 +32,7 @@
#include <xen/interface/vcpu.h>
#include <xen/interface/xenpmu.h>
+#include <asm/spec-ctrl.h>
#include <asm/xen/interface.h>
#include <asm/xen/hypercall.h>
@@ -70,6 +71,8 @@ static void cpu_bringup(void)
cpu_data(cpu).x86_max_cores = 1;
set_cpu_sibling_map(cpu);
+ speculative_store_bypass_ht_init();
+
xen_setup_cpu_clockevents();
notify_cpu_starting(cpu);
@@ -250,6 +253,8 @@ static void __init xen_pv_smp_prepare_cpus(unsigned int max_cpus)
}
set_cpu_sibling_map(0);
+ speculative_store_bypass_ht_init();
+
xen_pmu_init(0);
if (xen_smp_intr_init(0) || xen_smp_intr_init_pv(0))
--
2.13.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/xen: add call of speculative_store_bypass_ht_init() to pv paths
2018-06-21 8:43 [PATCH] x86/xen: add call of speculative_store_bypass_ht_init() to pv paths Juergen Gross
@ 2018-06-21 13:01 ` Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2018-06-21 13:01 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel, x86; +Cc: hpa, tglx, mingo, stable
On 06/21/2018 04:43 AM, Juergen Gross wrote:
> Commit 1f50ddb4f4189243c05926b842dc1a0332195f31 ("x86/speculation:
> Handle HT correctly on AMD") added speculative_store_bypass_ht_init()
> to the per-cpu initialization sequence.
>
> speculative_store_bypass_ht_init() needs to be called on each cpu for
> pv guests, too.
>
> Reported-by: Brian Woods <brian.woods@amd.com>
> Fixes: 1f50ddb4f4189243c05926b842dc1a0332195f31 ("x86/speculation: Handle HT correctly on AMD")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Tested-by: Brian Woods <brian.woods@amd.com>
>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-21 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-21 8:43 [PATCH] x86/xen: add call of speculative_store_bypass_ht_init() to pv paths Juergen Gross
2018-06-21 13:01 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®