[PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

[PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

[Geert Uytterhoeven]

If DEBUG_DMA is defined:

    include/asm/dma.h: In function ‘set_dma_mode’:
    include/asm/dma.h:393: error: ‘dmabp’ undeclared (first use in this function)
    include/asm/dma.h:393: error: (Each undeclared identifier is reported only once
    include/asm/dma.h:393: error: for each function it appears in.)
    include/asm/dma.h: In function ‘set_dma_addr’:
    include/asm/dma.h:424: error: ‘dmawp’ undeclared (first use in this function)

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@linux-m68k.org>
---
v2:
  - Add Acked-by.
---
 arch/m68k/include/asm/dma.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/m68k/include/asm/dma.h b/arch/m68k/include/asm/dma.h
index b0978a23bad1d7ee..ae2021964e32d36f 100644
--- a/arch/m68k/include/asm/dma.h
+++ b/arch/m68k/include/asm/dma.h
@@ -390,7 +390,7 @@ static __inline__ void set_dma_mode(unsigned int dmanr, char mode)
 
 #ifdef DEBUG_DMA
   printk("%s(%d): dmanr=%d DMR[%x]=%x DIR[%x]=%x\n", __FILE__, __LINE__,
-         dmanr, (int) &dmalp[MCFDMA_DMR], dmabp[MCFDMA_DMR],
+	 dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
 	 (int) &dmawp[MCFDMA_DIR], dmawp[MCFDMA_DIR]);
 #endif
 }
@@ -421,7 +421,7 @@ static __inline__ void set_dma_addr(unsigned int dmanr, unsigned int a)
 
 #ifdef DEBUG_DMA
   printk("%s(%d): dmanr=%d DMR[%x]=%x SAR[%x]=%08x DAR[%x]=%08x\n",
-	__FILE__, __LINE__, dmanr, (int) &dmawp[MCFDMA_DMR], dmawp[MCFDMA_DMR],
+	__FILE__, __LINE__, dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
 	(int) &dmalp[MCFDMA_DSAR], dmalp[MCFDMA_DSAR],
 	(int) &dmalp[MCFDMA_DDAR], dmalp[MCFDMA_DDAR]);
 #endif
-- 
2.17.1

Re: [PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

[Greg Ungerer]

Hi Geert,

On 22/06/18 06:30, Geert Uytterhoeven wrote:
> If DEBUG_DMA is defined:
> 
>      include/asm/dma.h: In function ‘set_dma_mode’:
>      include/asm/dma.h:393: error: ‘dmabp’ undeclared (first use in this function)
>      include/asm/dma.h:393: error: (Each undeclared identifier is reported only once
>      include/asm/dma.h:393: error: for each function it appears in.)
>      include/asm/dma.h: In function ‘set_dma_addr’:
>      include/asm/dma.h:424: error: ‘dmawp’ undeclared (first use in this function)
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Greg Ungerer <gerg@linux-m68k.org>

Do you want me to take this via the m68knommu git tree?

Regards
Greg


> ---
> v2:
>    - Add Acked-by.
> ---
>   arch/m68k/include/asm/dma.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/include/asm/dma.h b/arch/m68k/include/asm/dma.h
> index b0978a23bad1d7ee..ae2021964e32d36f 100644
> --- a/arch/m68k/include/asm/dma.h
> +++ b/arch/m68k/include/asm/dma.h
> @@ -390,7 +390,7 @@ static __inline__ void set_dma_mode(unsigned int dmanr, char mode)
>   
>   #ifdef DEBUG_DMA
>     printk("%s(%d): dmanr=%d DMR[%x]=%x DIR[%x]=%x\n", __FILE__, __LINE__,
> -         dmanr, (int) &dmalp[MCFDMA_DMR], dmabp[MCFDMA_DMR],
> +	 dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
>   	 (int) &dmawp[MCFDMA_DIR], dmawp[MCFDMA_DIR]);
>   #endif
>   }
> @@ -421,7 +421,7 @@ static __inline__ void set_dma_addr(unsigned int dmanr, unsigned int a)
>   
>   #ifdef DEBUG_DMA
>     printk("%s(%d): dmanr=%d DMR[%x]=%x SAR[%x]=%08x DAR[%x]=%08x\n",
> -	__FILE__, __LINE__, dmanr, (int) &dmawp[MCFDMA_DMR], dmawp[MCFDMA_DMR],
> +	__FILE__, __LINE__, dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
>   	(int) &dmalp[MCFDMA_DSAR], dmalp[MCFDMA_DSAR],
>   	(int) &dmalp[MCFDMA_DDAR], dmalp[MCFDMA_DDAR]);
>   #endif
> 

Re: [PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

[Geert Uytterhoeven]

Hi Greg,

On Fri, Jun 22, 2018 at 2:20 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
> On 22/06/18 06:30, Geert Uytterhoeven wrote:
> > If DEBUG_DMA is defined:
> >
> >      include/asm/dma.h: In function ‘set_dma_mode’:
> >      include/asm/dma.h:393: error: ‘dmabp’ undeclared (first use in this function)
> >      include/asm/dma.h:393: error: (Each undeclared identifier is reported only once
> >      include/asm/dma.h:393: error: for each function it appears in.)
> >      include/asm/dma.h: In function ‘set_dma_addr’:
> >      include/asm/dma.h:424: error: ‘dmawp’ undeclared (first use in this function)
> >
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Acked-by: Greg Ungerer <gerg@linux-m68k.org>
>
> Do you want me to take this via the m68knommu git tree?

Yes please. Thx!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

[Greg Ungerer]

Hi Geert,

On 22/06/18 16:35, Geert Uytterhoeven wrote:
> On Fri, Jun 22, 2018 at 2:20 AM Greg Ungerer <gerg@linux-m68k.org> wrote:
>> On 22/06/18 06:30, Geert Uytterhoeven wrote:
>>> If DEBUG_DMA is defined:
>>>
>>>       include/asm/dma.h: In function ‘set_dma_mode’:
>>>       include/asm/dma.h:393: error: ‘dmabp’ undeclared (first use in this function)
>>>       include/asm/dma.h:393: error: (Each undeclared identifier is reported only once
>>>       include/asm/dma.h:393: error: for each function it appears in.)
>>>       include/asm/dma.h: In function ‘set_dma_addr’:
>>>       include/asm/dma.h:424: error: ‘dmawp’ undeclared (first use in this function)
>>>
>>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Acked-by: Greg Ungerer <gerg@linux-m68k.org>
>>
>> Do you want me to take this via the m68knommu git tree?
> 
> Yes please. Thx!

Done!

Regards
Greg