From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding
Date: Fri, 22 Jun 2018 15:43:37 +0100 [thread overview]
Message-ID: <20180622144337.GB15386@sirena.org.uk> (raw)
In-Reply-To: <s5h8t77hz8y.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
On Fri, Jun 22, 2018 at 12:49:49PM +0200, Takashi Iwai wrote:
> Hm, some of these users (e.g. drivers/usb/core/*) do call
> of_node_put() properly at releasing, but some look leaking to me.
> I don't think we have the common code in the driver core to release
> dev->of_node, at least.
> If any, this should be done in ac97_codec_release(), I suppose.
Yeah, I'd expect this to be handled in each bus.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2018-06-22 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 15:43 [PATCH 1/2] ALSA: ac97: add bus binding for codecs Robert Jarzmik
2018-06-21 15:43 ` [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Robert Jarzmik
2018-06-21 19:45 ` Takashi Iwai
2018-06-22 10:41 ` Robert Jarzmik
2018-06-22 10:49 ` Takashi Iwai
2018-06-22 14:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180622144337.GB15386@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®