From: Takashi Iwai <tiwai@suse.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ALSA: ac97: add codecs devicetree binding
Date: Fri, 22 Jun 2018 12:49:49 +0200 [thread overview]
Message-ID: <s5h8t77hz8y.wl-tiwai@suse.de> (raw)
In-Reply-To: <874lhvnlx1.fsf@belgarion.home>
On Fri, 22 Jun 2018 12:41:14 +0200,
Robert Jarzmik wrote:
>
> Takashi Iwai <tiwai@suse.de> writes:
>
> >> Special review query: review the "return of_node_get(node)", which
> >> assumes that upon device removal, of_put_node(dev.of_node) will be
> >> called...
> >
> > Is it really done automagically? I couldn't spot it.
> Neither could I ...
>
> I based this on device_set_of_node_from_dev(), and the it "seemed" logical to me
> that a device probed from devicetree would take a refcnt on the devicetree node.
>
> As the "logical" conflicted with my search for the automagical of_node_get(), I
> need the special review query.
Hm, some of these users (e.g. drivers/usb/core/*) do call
of_node_put() properly at releasing, but some look leaking to me.
I don't think we have the common code in the driver core to release
dev->of_node, at least.
If any, this should be done in ac97_codec_release(), I suppose.
Takashi
next prev parent reply other threads:[~2018-06-22 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 15:43 [PATCH 1/2] ALSA: ac97: add bus binding for codecs Robert Jarzmik
2018-06-21 15:43 ` [PATCH 2/2] ALSA: ac97: add codecs devicetree binding Robert Jarzmik
2018-06-21 19:45 ` Takashi Iwai
2018-06-22 10:41 ` Robert Jarzmik
2018-06-22 10:49 ` Takashi Iwai [this message]
2018-06-22 14:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8t77hz8y.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®