From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Whitmore <arigead@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: Re: [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style
Date: Thu, 28 Jun 2018 10:38:28 +0300 [thread overview]
Message-ID: <20180628073828.hur7njmsstg2jwvx@mwanda> (raw)
In-Reply-To: <20180627202248.mvohkxjhwsv5hcn6@xux707-tw>
On Wed, Jun 27, 2018 at 09:22:50PM +0100, John Whitmore wrote:
> On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote:
> > On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote:
> > > Changed a number of hard coded function names to use %s and __func__
> > >
> > > Mailing list response suggest that there is a better method for debugging
> > > using netdev_dbg(). I can't argue with that, but for the moment this change
> > > will clear the checkpatch.pl Warning.
> > >
> > > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> > > ---
> > > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Did not apply :(
>
> No worries, can I just ask is that because it should be changed to use
> netdev_dbg as was suggested? And should that be across the whole file?
"Does not apply" means you save the raw email to email.txt then download
the latest code from
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
then `cat email.txt | git am` and it fails.
Probably someone else's patch was merged ahead of yours. Fix it up and
then resend.
regards,
dan carpenter
next prev parent reply other threads:[~2018-06-28 7:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 15:34 staging: rtl8192u: v3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:34 ` [PATCH v3 1/8] staging: rtl8192u: change block comments to prefered style - Coding Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 2/8] staging: rtl8192u: Correct indentation of switch statement " John Whitmore
2018-06-24 15:34 ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop John Whitmore
2018-06-25 9:06 ` Andy Shevchenko
2018-06-25 12:36 ` John Whitmore
2018-06-25 13:05 ` Justin Skists
2018-06-25 19:50 ` John Whitmore
2018-06-26 3:56 ` Greg Kroah-Hartman
2018-06-27 15:48 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 4/8] staging: rtl8192u: Truncate block comments to 80 character length - Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string " John Whitmore
2018-06-26 3:56 ` Greg KH
2018-06-27 20:22 ` John Whitmore
2018-06-28 7:38 ` Dan Carpenter [this message]
2018-06-28 12:32 ` John Whitmore
2018-06-28 12:48 ` Greg KH
2018-06-24 15:34 ` [PATCH v3 6/8] staging: rtl8192u: Remove braces from single statement blocks " John Whitmore
2018-06-24 15:34 ` [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style John Whitmore
2018-06-24 15:59 ` Joe Perches
2018-06-25 11:46 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 8/8] staging: rtl8192u: Correction of spelling mistake in comment John Whitmore
2018-06-24 15:40 staging: rtl8192u: V3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:40 ` [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628073828.hur7njmsstg2jwvx@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arigead@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®