From: Joe Perches <joe@perches.com>
To: John Whitmore <johnfwhitmore@gmail.com>, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style
Date: Sun, 24 Jun 2018 08:59:22 -0700 [thread overview]
Message-ID: <ed1a3747023af619d547e1ef7d593fd25b3abcb7.camel@perches.com> (raw)
In-Reply-To: <20180624153454.27356-8-johnfwhitmore@gmail.com>
On Sun, 2018-06-24 at 16:34 +0100, John Whitmore wrote:
> Corrected the coding style of if statement.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
[]
> @@ -732,7 +732,7 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
> section of code.
> if(IS_UNDER_11N_AES_MODE(Adapter))
> {
> - posRT2RTAgg->Octet[5] |=RT_HT_CAP_USE_AMPDU;
> + posRT2RTAgg->Octet[5] |= RT_HT_CAP_USE_AMPDU;
> }else
> {
> posRT2RTAgg->Octet[5] &= 0xfb;
Rather than doing individual patches for each line
with a whitespace issue, I think it'd be better to
do a single driver wide patch.
Perhaps use a tool like:
$ git ls-files drivers/staging/rtl8192u |
xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing
where:
$ git diff -w drivers/staging/rtl8192u/
should not show a single difference.
Then compile and commit that as a single patch with
something like "use a more typical spacing style"
as the commit message.
next prev parent reply other threads:[~2018-06-24 15:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-24 15:34 staging: rtl8192u: v3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:34 ` [PATCH v3 1/8] staging: rtl8192u: change block comments to prefered style - Coding Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 2/8] staging: rtl8192u: Correct indentation of switch statement " John Whitmore
2018-06-24 15:34 ` [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop John Whitmore
2018-06-25 9:06 ` Andy Shevchenko
2018-06-25 12:36 ` John Whitmore
2018-06-25 13:05 ` Justin Skists
2018-06-25 19:50 ` John Whitmore
2018-06-26 3:56 ` Greg Kroah-Hartman
2018-06-27 15:48 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 4/8] staging: rtl8192u: Truncate block comments to 80 character length - Style John Whitmore
2018-06-24 15:34 ` [PATCH v3 5/8] staging: rtl8192u: Use %s and __func__ instead of hardcoded string " John Whitmore
2018-06-26 3:56 ` Greg KH
2018-06-27 20:22 ` John Whitmore
2018-06-28 7:38 ` Dan Carpenter
2018-06-28 12:32 ` John Whitmore
2018-06-28 12:48 ` Greg KH
2018-06-24 15:34 ` [PATCH v3 6/8] staging: rtl8192u: Remove braces from single statement blocks " John Whitmore
2018-06-24 15:34 ` [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style John Whitmore
2018-06-24 15:59 ` Joe Perches [this message]
2018-06-25 11:46 ` John Whitmore
2018-06-24 15:34 ` [PATCH v3 8/8] staging: rtl8192u: Correction of spelling mistake in comment John Whitmore
2018-06-24 15:40 staging: rtl8192u: V3 Coding style changes. Plus one change to use memset() John Whitmore
2018-06-24 15:40 ` [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding Style John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed1a3747023af619d547e1ef7d593fd25b3abcb7.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®