mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manfred Spraul <manfred@colorfullife.com>
To: LKML <linux-kernel@vger.kernel.org>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Dmitry Vyukov <dvyukov@google.com>
Cc: 1vier1@web.de, Andrew Morton <akpm@linux-foundation.org>,
	Kees Cook <keescook@chromium.org>,
	Manfred Spraul <manfred@colorfullife.com>
Subject: [PATCH 6/6] ipc/util.c: correct comment in ipc_obtain_object_check
Date: Thu,  5 Jul 2018 07:59:20 +0200	[thread overview]
Message-ID: <20180705055920.19611-7-manfred@colorfullife.com> (raw)
In-Reply-To: <20180705055920.19611-1-manfred@colorfullife.com>

The comment that explains ipc_obtain_object_check is wrong:
The function checks the sequence number, not the reference
counter.
Note that checking the reference counter would be meaningless:
The reference counter is decreased without holding any locks,
thus an object with kern_ipc_perm.deleted=true may disappear at
the end of the next rcu grace period.

Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
---
 ipc/util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipc/util.c b/ipc/util.c
index 4f2db913acf9..776a9ce2905f 100644
--- a/ipc/util.c
+++ b/ipc/util.c
@@ -646,8 +646,8 @@ struct kern_ipc_perm *ipc_lock_idr(struct ipc_ids *ids, int id)
  * @ids: ipc identifier set
  * @id: ipc id to look for
  *
- * Similar to ipc_obtain_object_idr() but also checks
- * the ipc object reference counter.
+ * Similar to ipc_obtain_object_idr() but also checks the ipc object
+ * sequence number.
  *
  * Call inside the RCU critical section.
  * The ipc object is *not* locked on exit.
-- 
2.17.1


      parent reply	other threads:[~2018-07-05  6:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05  5:59 [PATCH 0/5] ipc: cleanups & bugfixes Manfred Spraul
2018-07-05  5:59 ` [PATCH 1/6] ipc: reorganize initialization of kern_ipc_perm.id Manfred Spraul
2018-07-05  5:59 ` [PATCH 2/6] ipc: reorganize initialization of kern_ipc_perm.seq Manfred Spraul
2018-07-05  8:36   ` Dmitry Vyukov
2018-07-05 15:12     ` Manfred Spraul
2018-07-05 16:08       ` Dmitry Vyukov
2018-07-05 21:56       ` Andrew Morton
2018-07-06 17:18         ` Davidlohr Bueso
2018-07-05  5:59 ` [PATCH 3/6] ipc/util.c: Use ipc_rcu_putref() for failues in ipc_addid() Manfred Spraul
2018-07-05  5:59 ` [PATCH 4/6] ipc: Rename ipcctl_pre_down_nolock() Manfred Spraul
2018-07-05  5:59 ` [PATCH 5/6] ipc: rename ipc_lock() to ipc_lock_idr() Manfred Spraul
2018-07-05  5:59 ` Manfred Spraul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705055920.19611-7-manfred@colorfullife.com \
    --to=manfred@colorfullife.com \
    --cc=1vier1@web.de \
    --cc=akpm@linux-foundation.org \
    --cc=dave@stgolabs.net \
    --cc=dvyukov@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®