From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tamir Suliman <tsuliman@linuxvaults.com>
Cc: Justin Skists <justin.skists@juzza.co.uk>,
w.d.hubbs@gmail.com, gregkh@linuxfoundation.org,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
dhowells@redhat.com, linux-kernel@vger.kernel.org,
chris@the-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
Date: Thu, 5 Jul 2018 14:46:00 +0300 [thread overview]
Message-ID: <20180705114600.f27xfsro3yucorrt@mwanda> (raw)
In-Reply-To: <fb7d3816-255d-15e7-b9ef-533b1167f73c@linuxvaults.com>
On Wed, Jul 04, 2018 at 10:46:05PM +0300, Tamir Suliman wrote:
>
> Interesting construct... Yeah I'm little bit rusty on my C /programming .
> I understand proper coding style may be should end with else so I wasn't
> sure .. however this resolved the warnings. :)
The code you wrote was very wrong.
It doesn't compile. You need to figure out what is wrong with your
testing so that it doesn't happen again.
regards,
dan carpenter
next prev parent reply other threads:[~2018-07-05 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 7:31 Tamir Suliman
2018-07-03 7:40 ` Greg KH
2018-07-03 8:10 ` Justin Skists
2018-07-04 19:46 ` Tamir Suliman
2018-07-05 11:46 ` Dan Carpenter [this message]
2018-07-05 11:55 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705114600.f27xfsro3yucorrt@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=justin.skists@juzza.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=tsuliman@linuxvaults.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®