From: Dan Carpenter <dan.carpenter@oracle.com>
To: Justin Skists <justin.skists@juzza.co.uk>
Cc: w.d.hubbs@gmail.com, gregkh@linuxfoundation.org,
speakup@linux-speakup.org,
Tamir Suliman <tsuliman@linuxvaults.com>,
devel@driverdev.osuosl.org, dhowells@redhat.com,
linux-kernel@vger.kernel.org, chris@the-brannons.com
Subject: Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings
Date: Thu, 5 Jul 2018 14:55:49 +0300 [thread overview]
Message-ID: <20180705115549.wifgpi5qe6dfkcoj@mwanda> (raw)
In-Reply-To: <1527895743.93688.1530605455516@email.1and1.co.uk>
On Tue, Jul 03, 2018 at 09:10:55AM +0100, Justin Skists wrote:
> > @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,
> > continue;
> > }
> >
> > - index = simple_strtoul(cp, &temp, 10);
> > + index = simple_ktrtoul(cp, &temp, 10);
>
> Did you compile this?
Try to avoid rhetorical questions. Just say "This doesn't compile. Be
more careful."
regards,
dan carpenter
prev parent reply other threads:[~2018-07-05 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 7:31 Tamir Suliman
2018-07-03 7:40 ` Greg KH
2018-07-03 8:10 ` Justin Skists
2018-07-04 19:46 ` Tamir Suliman
2018-07-05 11:46 ` Dan Carpenter
2018-07-05 11:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180705115549.wifgpi5qe6dfkcoj@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=justin.skists@juzza.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=tsuliman@linuxvaults.com \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®