From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: LKML <linux-kernel@vger.kernel.org>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>,
Joerg Roedel <jroedel@suse.de>
Subject: [PATCH 05/12] dmar: Use for_each_If
Date: Mon, 9 Jul 2018 10:36:43 +0200 [thread overview]
Message-ID: <20180709083650.23549-5-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20180709083650.23549-1-daniel.vetter@ffwll.ch>
Avoids the inverted conditions compared to the open coded version.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Joerg Roedel <jroedel@suse.de>
---
include/linux/dmar.h | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/linux/dmar.h b/include/linux/dmar.h
index e2433bc50210..99397504e75e 100644
--- a/include/linux/dmar.h
+++ b/include/linux/dmar.h
@@ -85,15 +85,15 @@ extern struct list_head dmar_drhd_units;
#define for_each_active_drhd_unit(drhd) \
list_for_each_entry_rcu(drhd, &dmar_drhd_units, list) \
- if (drhd->ignored) {} else
+ for_each_if (!drhd->ignored)
#define for_each_active_iommu(i, drhd) \
list_for_each_entry_rcu(drhd, &dmar_drhd_units, list) \
- if (i=drhd->iommu, drhd->ignored) {} else
+ for_each_if ((i=drhd->iommu, !drhd->ignored))
#define for_each_iommu(i, drhd) \
list_for_each_entry_rcu(drhd, &dmar_drhd_units, list) \
- if (i=drhd->iommu, 0) {} else
+ for_each_if ((i=drhd->iommu, true))
static inline bool dmar_rcu_check(void)
{
@@ -108,7 +108,8 @@ static inline bool dmar_rcu_check(void)
NULL, (p) < (c)); (p)++)
#define for_each_active_dev_scope(a, c, p, d) \
- for_each_dev_scope((a), (c), (p), (d)) if (!(d)) { continue; } else
+ for_each_dev_scope((a), (c), (p), (d)) \
+ for_each_if (d)
extern int dmar_table_init(void);
extern int dmar_dev_scope_init(void);
--
2.18.0
next prev parent reply other threads:[~2018-07-09 8:44 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:36 [PATCH 01/12] kernel.h: Add for_each_if() Daniel Vetter
2018-07-09 8:36 ` [PATCH 02/12] blk: use for_each_if Daniel Vetter
2018-07-11 16:40 ` Tejun Heo
2018-07-11 16:45 ` Tejun Heo
2018-07-11 18:30 ` Jens Axboe
2018-07-11 18:50 ` Daniel Vetter
2018-07-11 19:31 ` Jens Axboe
2018-07-11 20:06 ` Tejun Heo
2018-07-11 21:08 ` Daniel Vetter
2018-07-11 21:13 ` Jens Axboe
2018-07-12 6:41 ` Daniel Vetter
2018-07-12 6:45 ` Joe Perches
2018-07-12 13:54 ` Jens Axboe
2018-07-12 15:32 ` Joe Perches
2018-07-13 9:28 ` Vlastimil Babka
2018-07-09 8:36 ` [PATCH 03/12] cgroup: " Daniel Vetter
2018-07-11 16:46 ` Tejun Heo
2018-07-09 8:36 ` [PATCH 04/12] cpufreq: " Daniel Vetter
2018-07-09 9:28 ` Eric Engestrom
2018-07-09 16:11 ` [PATCH] " Daniel Vetter
2018-07-09 21:36 ` Rafael J. Wysocki
2018-07-09 8:36 ` Daniel Vetter [this message]
2018-07-20 12:50 ` [PATCH 05/12] dmar: Use for_each_If Joerg Roedel
2018-07-09 8:36 ` [PATCH 06/12] mm: use for_each_if Daniel Vetter
2018-07-09 18:00 ` Pavel Tatashin
2018-07-09 8:36 ` [PATCH 07/12] ide: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 08/12] netdev: " Daniel Vetter
2018-07-09 8:36 ` [PATCH 09/12] nubus: " Daniel Vetter
2018-07-09 10:17 ` Finn Thain
2018-07-17 15:26 ` Geert Uytterhoeven
2018-07-09 8:36 ` [PATCH 10/12] pci: " Daniel Vetter
2018-07-09 22:48 ` Bjorn Helgaas
2018-07-09 8:36 ` [PATCH 11/12] sched: use for_each_if in topology.h Daniel Vetter
2018-07-09 10:36 ` Peter Zijlstra
2018-07-09 15:00 ` Daniel Vetter
2018-07-09 15:12 ` Peter Zijlstra
2018-07-09 15:52 ` Daniel Vetter
2018-07-09 16:03 ` Peter Zijlstra
2018-07-09 16:06 ` Daniel Vetter
2018-07-09 16:12 ` Mark Rutland
2018-07-09 17:55 ` [Intel-gfx] " Daniel Vetter
2018-07-11 16:51 ` Mark Rutland
2018-07-09 16:30 ` Peter Zijlstra
2018-07-09 8:36 ` [PATCH 12/12] usb: use for_each_if Daniel Vetter
2018-07-09 11:50 ` [PATCH 01/12] kernel.h: Add for_each_if() Andy Shevchenko
2018-07-09 16:25 ` [PATCH] " Daniel Vetter
2018-07-09 18:30 ` Andy Shevchenko
2018-07-09 23:30 ` Andrew Morton
2018-07-10 7:53 ` Daniel Vetter
2018-07-10 10:32 ` NeilBrown
2018-07-11 11:51 ` Daniel Vetter
2018-07-11 23:05 ` Andrew Morton
2018-07-12 6:39 ` Daniel Vetter
2018-07-13 23:37 ` NeilBrown
2018-07-13 23:42 ` Randy Dunlap
2018-07-16 8:11 ` Andy Shevchenko
2018-07-16 15:41 ` Randy Dunlap
2018-07-16 22:16 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709083650.23549-5-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®