mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] pinctrl: ocelot: fix gpio4 twi function
@ 2018-07-11 13:01 Alexandre Belloni
  2018-07-13  7:41 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre Belloni @ 2018-07-11 13:01 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Alexandre Belloni

the TWI function on GPIO4 is actually a multiplexed SCL, not an original
TWI SDA or SCL. Fix it.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/pinctrl/pinctrl-ocelot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
index 15bb1cb8729b..e93669f4d1c8 100644
--- a/drivers/pinctrl/pinctrl-ocelot.c
+++ b/drivers/pinctrl/pinctrl-ocelot.c
@@ -132,7 +132,7 @@ OCELOT_P(0,  SG0,       NONE,      NONE);
 OCELOT_P(1,  SG0,       NONE,      NONE);
 OCELOT_P(2,  SG0,       NONE,      NONE);
 OCELOT_P(3,  SG0,       NONE,      NONE);
-OCELOT_P(4,  IRQ0_IN,   IRQ0_OUT,  TWI);
+OCELOT_P(4,  IRQ0_IN,   IRQ0_OUT,  TWI_SCL_M);
 OCELOT_P(5,  IRQ1_IN,   IRQ1_OUT,  PCI_WAKE);
 OCELOT_P(6,  UART,      TWI_SCL_M, NONE);
 OCELOT_P(7,  UART,      TWI_SCL_M, NONE);
-- 
2.18.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: ocelot: fix gpio4 twi function
  2018-07-11 13:01 [PATCH] pinctrl: ocelot: fix gpio4 twi function Alexandre Belloni
@ 2018-07-13  7:41 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-07-13  7:41 UTC (permalink / raw)
  To: Alexandre Belloni; +Cc: open list:GPIO SUBSYSTEM, linux-kernel

On Wed, Jul 11, 2018 at 3:01 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:

> the TWI function on GPIO4 is actually a multiplexed SCL, not an original
> TWI SDA or SCL. Fix it.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-07-13  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 13:01 [PATCH] pinctrl: ocelot: fix gpio4 twi function Alexandre Belloni
2018-07-13  7:41 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome