From: rkir@google.com
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, tkjos@google.com,
Roman Kiryanov <rkir@google.com>
Subject: [PATCH 3/3] tty: Mark goldfish_tty_line_count as const
Date: Tue, 17 Jul 2018 17:14:55 -0700 [thread overview]
Message-ID: <20180718001455.140575-3-rkir@google.com> (raw)
In-Reply-To: <20180718001455.140575-1-rkir@google.com>
From: Roman Kiryanov <rkir@google.com>
The driver never mutates this variable - no benefits of
keeping it mutable.
Signed-off-by: Roman Kiryanov <rkir@google.com>
---
drivers/tty/goldfish.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index a9c8ab8a4750..32b77bf54918 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -49,7 +49,7 @@ struct goldfish_tty {
static DEFINE_MUTEX(goldfish_tty_lock);
static struct tty_driver *goldfish_tty_driver;
-static u32 goldfish_tty_line_count = 8;
+static const u32 goldfish_tty_line_count = 8;
static u32 goldfish_tty_current_line_count;
static struct goldfish_tty *goldfish_ttys;
--
2.18.0.203.gfac676dfb9-goog
next prev parent reply other threads:[~2018-07-18 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 0:14 [PATCH 1/3] tty: Address checkpatch warnings in goldfish.c rkir
2018-07-18 0:14 ` [PATCH 2/3] tty: Make constants to be enums instead of #define " rkir
2018-07-21 7:45 ` Greg KH
2018-07-18 0:14 ` rkir [this message]
2018-07-21 7:46 ` [PATCH 3/3] tty: Mark goldfish_tty_line_count as const Greg KH
2018-07-24 20:00 ` Roman Kiryanov
2018-07-21 7:44 ` [PATCH 1/3] tty: Address checkpatch warnings in goldfish.c Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718001455.140575-3-rkir@google.com \
--to=rkir@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®