mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: rkir@google.com
Cc: linux-kernel@vger.kernel.org, tkjos@google.com
Subject: Re: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c
Date: Sat, 21 Jul 2018 09:45:21 +0200	[thread overview]
Message-ID: <20180721074521.GB6484@kroah.com> (raw)
In-Reply-To: <20180718001455.140575-2-rkir@google.com>

On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> enums produce better compilation errors than defines.

Yes, if you name the enum.  But you didn't do that here, so this patch
really does not do anything to cause any "protection" at all :(

Please fix this up and resend.

thanks,

greg k-h

  reply	other threads:[~2018-07-21  7:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  0:14 [PATCH 1/3] tty: Address checkpatch warnings " rkir
2018-07-18  0:14 ` [PATCH 2/3] tty: Make constants to be enums instead of #define " rkir
2018-07-21  7:45   ` Greg KH [this message]
2018-07-18  0:14 ` [PATCH 3/3] tty: Mark goldfish_tty_line_count as const rkir
2018-07-21  7:46   ` Greg KH
2018-07-24 20:00     ` Roman Kiryanov
2018-07-21  7:44 ` [PATCH 1/3] tty: Address checkpatch warnings in goldfish.c Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180721074521.GB6484@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkir@google.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®