mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] power:ds2782:Fix description error
@ 2018-07-18 15:20 elicec
  2018-07-22 22:09 ` Sebastian Reichel
  0 siblings, 1 reply; 3+ messages in thread
From: elicec @ 2018-07-18 15:20 UTC (permalink / raw)
  To: sre, linux-pm, linux-kernel; +Cc: elicec

After add support for ds2786 battery gas gauge,the description
didn't update. fix it.

Signed-off-by: elicec <elicec@foxmail.com>
---
 drivers/power/supply/ds2782_battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/ds2782_battery.c b/drivers/power/supply/ds2782_battery.c
index a1b7e0592245..924e99d1e69e 100644
--- a/drivers/power/supply/ds2782_battery.c
+++ b/drivers/power/supply/ds2782_battery.c
@@ -471,5 +471,5 @@ static struct i2c_driver ds278x_battery_driver = {
 module_i2c_driver(ds278x_battery_driver);
 
 MODULE_AUTHOR("Ryan Mallon");
-MODULE_DESCRIPTION("Maxim/Dallas DS2782 Stand-Alone Fuel Gauage IC driver");
+MODULE_DESCRIPTION("Maxim/Dallas DS2782/DS2786 Stand-Alone Fuel Gauage IC driver");
 MODULE_LICENSE("GPL");
-- 
2.17.1




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power:ds2782:Fix description error
  2018-07-18 15:20 [PATCH] power:ds2782:Fix description error elicec
@ 2018-07-22 22:09 ` Sebastian Reichel
  0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2018-07-22 22:09 UTC (permalink / raw)
  To: elicec; +Cc: linux-pm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

Hi Elicec,

On Wed, Jul 18, 2018 at 03:20:33PM +0000, elicec wrote:
> After add support for ds2786 battery gas gauge,the description
> didn't update. fix it.
> 
> Signed-off-by: elicec <elicec@foxmail.com>
> ---

Thanks for the patch. The change looks good, but the subject of the
patch should be prefixed with "power: supply: ds2782: ". Even more
importantly we don't accept patch contributions, that are using
pseudonyms:

Documentation/process/submitting-patches.rst

-- Sebastian

>  drivers/power/supply/ds2782_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ds2782_battery.c b/drivers/power/supply/ds2782_battery.c
> index a1b7e0592245..924e99d1e69e 100644
> --- a/drivers/power/supply/ds2782_battery.c
> +++ b/drivers/power/supply/ds2782_battery.c
> @@ -471,5 +471,5 @@ static struct i2c_driver ds278x_battery_driver = {
>  module_i2c_driver(ds278x_battery_driver);
>  
>  MODULE_AUTHOR("Ryan Mallon");
> -MODULE_DESCRIPTION("Maxim/Dallas DS2782 Stand-Alone Fuel Gauage IC driver");
> +MODULE_DESCRIPTION("Maxim/Dallas DS2782/DS2786 Stand-Alone Fuel Gauage IC driver");
>  MODULE_LICENSE("GPL");
> -- 
> 2.17.1
> 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power:ds2782:Fix description error
       [not found] <tencent_408CB7922C1972D02ACDB8E48E4218092507@qq.com>
@ 2019-04-05 15:58 ` sre
  0 siblings, 0 replies; 3+ messages in thread
From: sre @ 2019-04-05 15:58 UTC (permalink / raw)
  To: 彭红; +Cc: linux-pm, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Hi,

On Wed, Feb 20, 2019 at 04:32:29PM +0800, 彭红 wrote:
> After add support for ds2786 battery gas gauge,the description
> didn't update. fix it.
> 
> Signed-off-by: HongPeng <elicec@foxmail.com>
> ---

The patch does not apply due to a spelling fix in the description
(Gauage -> Gauge). Also your name in From does not match the name
in the Signed-off-by (SoB) and the one from SoB seems to miss a
space.

-- Sebastian

>  drivers/power/supply/ds2782_battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/ds2782_battery.c b/drivers/power/supply/ds2782_battery.c
> index a1b7e0592245..924e99d1e69e 100644
> --- a/drivers/power/supply/ds2782_battery.c
> +++ b/drivers/power/supply/ds2782_battery.c
> @@ -471,5 +471,5 @@ static struct i2c_driver ds278x_battery_driver = {
>  module_i2c_driver(ds278x_battery_driver);
>  
>  MODULE_AUTHOR("Ryan Mallon");
> -MODULE_DESCRIPTION("Maxim/Dallas DS2782 Stand-Alone Fuel Gauage IC driver");
> +MODULE_DESCRIPTION("Maxim/Dallas DS2782/DS2786 Stand-Alone Fuel Gauage IC driver");
>  MODULE_LICENSE("GPL");
> -- 
> 2.17.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-05 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 15:20 [PATCH] power:ds2782:Fix description error elicec
2018-07-22 22:09 ` Sebastian Reichel
     [not found] <tencent_408CB7922C1972D02ACDB8E48E4218092507@qq.com>
2019-04-05 15:58 ` sre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome