* drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used
@ 2018-07-19 23:42 kbuild test robot
2018-07-19 23:42 ` [PATCH] PCI: fix ptr_ret.cocci warnings kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-07-19 23:42 UTC (permalink / raw)
To: Shawn Lin; +Cc: kbuild-all, linux-kernel, Bjorn Helgaas
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: fb7d1bcf1602b46f37ada72178516c01a250e434
commit: 6e0832fa432ec99c94caee733c8f5851cf85560b PCI: Collect all native drivers under drivers/pci/controller/
date: 6 weeks ago
coccinelle warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] PCI: fix ptr_ret.cocci warnings 2018-07-19 23:42 drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot @ 2018-07-19 23:42 ` kbuild test robot 2018-09-18 14:21 ` Lorenzo Pieralisi 0 siblings, 1 reply; 4+ messages in thread From: kbuild test robot @ 2018-07-19 23:42 UTC (permalink / raw) To: Shawn Lin Cc: kbuild-all, linux-kernel, Bjorn Helgaas, Xiaowei Song, Binghui Wang, Lorenzo Pieralisi, linux-pci From: kbuild test robot <fengguang.wu@intel.com> drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/") CC: Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by: kbuild test robot <fengguang.wu@intel.com> --- pcie-kirin.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -138,10 +138,7 @@ static long kirin_pcie_get_clk(struct ki return PTR_ERR(kirin_pcie->apb_sys_clk); kirin_pcie->pcie_aclk = devm_clk_get(dev, "pcie_aclk"); - if (IS_ERR(kirin_pcie->pcie_aclk)) - return PTR_ERR(kirin_pcie->pcie_aclk); - - return 0; + return PTR_ERR_OR_ZERO(kirin_pcie->pcie_aclk); } static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie, @@ -174,10 +171,7 @@ static long kirin_pcie_get_resource(stru kirin_pcie->sysctrl = syscon_regmap_lookup_by_compatible("hisilicon,hi3660-sctrl"); - if (IS_ERR(kirin_pcie->sysctrl)) - return PTR_ERR(kirin_pcie->sysctrl); - - return 0; + return PTR_ERR_OR_ZERO(kirin_pcie->sysctrl); } static int kirin_pcie_phy_init(struct kirin_pcie *kirin_pcie) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PCI: fix ptr_ret.cocci warnings 2018-07-19 23:42 ` [PATCH] PCI: fix ptr_ret.cocci warnings kbuild test robot @ 2018-09-18 14:21 ` Lorenzo Pieralisi 2018-09-19 0:40 ` Songxiaowei (Kirin_DRV) 0 siblings, 1 reply; 4+ messages in thread From: Lorenzo Pieralisi @ 2018-09-18 14:21 UTC (permalink / raw) To: kbuild test robot, Xiaowei Song, Binghui Wang Cc: Shawn Lin, kbuild-all, linux-kernel, Bjorn Helgaas On Fri, Jul 20, 2018 at 07:42:43AM +0800, kbuild test robot wrote: > From: kbuild test robot <fengguang.wu@intel.com> > > drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used > drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes: 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/") > CC: Shawn Lin <shawn.lin@rock-chips.com> > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > --- > > pcie-kirin.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Xiaowei, Binghui, are you OK with this change ? I will remove the Fixes: tag from the patch. Let me know, thanks. Lorenzo > --- a/drivers/pci/controller/dwc/pcie-kirin.c > +++ b/drivers/pci/controller/dwc/pcie-kirin.c > @@ -138,10 +138,7 @@ static long kirin_pcie_get_clk(struct ki > return PTR_ERR(kirin_pcie->apb_sys_clk); > > kirin_pcie->pcie_aclk = devm_clk_get(dev, "pcie_aclk"); > - if (IS_ERR(kirin_pcie->pcie_aclk)) > - return PTR_ERR(kirin_pcie->pcie_aclk); > - > - return 0; > + return PTR_ERR_OR_ZERO(kirin_pcie->pcie_aclk); > } > > static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie, > @@ -174,10 +171,7 @@ static long kirin_pcie_get_resource(stru > > kirin_pcie->sysctrl = > syscon_regmap_lookup_by_compatible("hisilicon,hi3660-sctrl"); > - if (IS_ERR(kirin_pcie->sysctrl)) > - return PTR_ERR(kirin_pcie->sysctrl); > - > - return 0; > + return PTR_ERR_OR_ZERO(kirin_pcie->sysctrl); > } > > static int kirin_pcie_phy_init(struct kirin_pcie *kirin_pcie) ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] PCI: fix ptr_ret.cocci warnings 2018-09-18 14:21 ` Lorenzo Pieralisi @ 2018-09-19 0:40 ` Songxiaowei (Kirin_DRV) 0 siblings, 0 replies; 4+ messages in thread From: Songxiaowei (Kirin_DRV) @ 2018-09-19 0:40 UTC (permalink / raw) To: Lorenzo Pieralisi, kbuild test robot, Wangbinghui (Biggio, Kirin_DRV) Cc: Shawn Lin, kbuild-all, linux-kernel, Bjorn Helgaas That's OK, and thank a lot. > -----Original Message----- > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com] > Sent: Tuesday, September 18, 2018 10:21 PM > To: kbuild test robot <fengguang.wu@intel.com>; Songxiaowei (Kirin_DRV) > <songxiaowei@hisilicon.com>; Wangbinghui (Biggio, Kirin_DRV) > <wangbinghui@hisilicon.com> > Cc: Shawn Lin <shawn.lin@rock-chips.com>; kbuild-all@01.org; > linux-kernel@vger.kernel.org; Bjorn Helgaas <helgaas@kernel.org> > Subject: Re: [PATCH] PCI: fix ptr_ret.cocci warnings > > On Fri, Jul 20, 2018 at 07:42:43AM +0800, kbuild test robot wrote: > > From: kbuild test robot <fengguang.wu@intel.com> > > > > drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: > > PTR_ERR_OR_ZERO can be used > > drivers/pci/controller/dwc/pcie-kirin.c:177:1-3: WARNING: > > PTR_ERR_OR_ZERO can be used > > > > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > > > Fixes: 6e0832fa432e ("PCI: Collect all native drivers under > > drivers/pci/controller/") > > CC: Shawn Lin <shawn.lin@rock-chips.com> > > Signed-off-by: kbuild test robot <fengguang.wu@intel.com> > > --- > > > > pcie-kirin.c | 10 ++-------- > > 1 file changed, 2 insertions(+), 8 deletions(-) > > Xiaowei, Binghui, > > are you OK with this change ? I will remove the Fixes: tag from the patch. > > Let me know, thanks. > > Lorenzo > > > --- a/drivers/pci/controller/dwc/pcie-kirin.c > > +++ b/drivers/pci/controller/dwc/pcie-kirin.c > > @@ -138,10 +138,7 @@ static long kirin_pcie_get_clk(struct ki > > return PTR_ERR(kirin_pcie->apb_sys_clk); > > > > kirin_pcie->pcie_aclk = devm_clk_get(dev, "pcie_aclk"); > > - if (IS_ERR(kirin_pcie->pcie_aclk)) > > - return PTR_ERR(kirin_pcie->pcie_aclk); > > - > > - return 0; > > + return PTR_ERR_OR_ZERO(kirin_pcie->pcie_aclk); > > } > > > > static long kirin_pcie_get_resource(struct kirin_pcie *kirin_pcie, @@ > > -174,10 +171,7 @@ static long kirin_pcie_get_resource(stru > > > > kirin_pcie->sysctrl = > > syscon_regmap_lookup_by_compatible("hisilicon,hi3660-sctrl"); > > - if (IS_ERR(kirin_pcie->sysctrl)) > > - return PTR_ERR(kirin_pcie->sysctrl); > > - > > - return 0; > > + return PTR_ERR_OR_ZERO(kirin_pcie->sysctrl); > > } > > > > static int kirin_pcie_phy_init(struct kirin_pcie *kirin_pcie) ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-19 0:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-07-19 23:42 drivers/pci/controller/dwc/pcie-kirin.c:141:1-3: WARNING: PTR_ERR_OR_ZERO can be used kbuild test robot 2018-07-19 23:42 ` [PATCH] PCI: fix ptr_ret.cocci warnings kbuild test robot 2018-09-18 14:21 ` Lorenzo Pieralisi 2018-09-19 0:40 ` Songxiaowei (Kirin_DRV)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®