Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]

Hi Chen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.18-rc6 next-20180723]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chen-Lin/sched-numa-do-not-balance-tasks-onto-isolated-cpus/20180724-031803
config: x86_64-randconfig-x008-201829 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel//sched/fair.c: In function 'task_numa_find_cpu':
>> kernel//sched/fair.c:1726:46: error: 'cpu_isolated_map' undeclared (first use in this function); did you mean 'cpu_core_map'?
                        || cpumask_test_cpu(cpu, cpu_isolated_map))
                                                 ^~~~~~~~~~~~~~~~
                                                 cpu_core_map
   kernel//sched/fair.c:1726:46: note: each undeclared identifier is reported only once for each function it appears in

vim +1726 kernel//sched/fair.c

  1717	
  1718	static void task_numa_find_cpu(struct task_numa_env *env,
  1719					long taskimp, long groupimp)
  1720	{
  1721		int cpu;
  1722	
  1723		for_each_cpu(cpu, cpumask_of_node(env->dst_nid)) {
  1724			/* Skip this CPU if the source task cannot migrate */
  1725			if ((!cpumask_test_cpu(cpu, &env->p->cpus_allowed))
> 1726	                    || cpumask_test_cpu(cpu, cpu_isolated_map))
  1727				continue;
  1728	
  1729			env->dst_cpu = cpu;
  1730			task_numa_compare(env, taskimp, groupimp);
  1731		}
  1732	}
  1733	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27462 bytes --]