Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2576 bytes --]

Hi Chen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on v4.18-rc6 next-20180723]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chen-Lin/sched-numa-do-not-balance-tasks-onto-isolated-cpus/20180724-031803
config: i386-randconfig-x008-201829 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel/sched/core.c: In function 'migrate_swap':
>> kernel/sched/core.c:1283:46: error: 'cpu_isolated_map' undeclared (first use in this function); did you mean 'cpu_core_map'?
                || cpumask_test_cpu(arg.dst_cpu, cpu_isolated_map))
                                                 ^~~~~~~~~~~~~~~~
                                                 cpu_core_map
   kernel/sched/core.c:1283:46: note: each undeclared identifier is reported only once for each function it appears in

vim +1283 kernel/sched/core.c

  1256	
  1257	/*
  1258	 * Cross migrate two tasks
  1259	 */
  1260	int migrate_swap(struct task_struct *cur, struct task_struct *p)
  1261	{
  1262		struct migration_swap_arg arg;
  1263		int ret = -EINVAL;
  1264	
  1265		arg = (struct migration_swap_arg){
  1266			.src_task = cur,
  1267			.src_cpu = task_cpu(cur),
  1268			.dst_task = p,
  1269			.dst_cpu = task_cpu(p),
  1270		};
  1271	
  1272		if (arg.src_cpu == arg.dst_cpu)
  1273			goto out;
  1274	
  1275		/*
  1276		 * These three tests are all lockless; this is OK since all of them
  1277		 * will be re-checked with proper locks held further down the line.
  1278		 */
  1279		if (!cpu_active(arg.src_cpu) || !cpu_active(arg.dst_cpu))
  1280			goto out;
  1281	
  1282		if ((!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> 1283	            || cpumask_test_cpu(arg.dst_cpu, cpu_isolated_map))
  1284			goto out;
  1285	
  1286		if ((!cpumask_test_cpu(arg.src_cpu, &arg.dst_task->cpus_allowed))
  1287	            || cpumask_test_cpu(arg.src_cpu, cpu_isolated_map))
  1288			goto out;
  1289	
  1290		trace_sched_swap_numa(cur, arg.src_cpu, p, arg.dst_cpu);
  1291		ret = stop_two_cpus(arg.dst_cpu, arg.src_cpu, migrate_swap_stop, &arg);
  1292	
  1293	out:
  1294		return ret;
  1295	}
  1296	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25146 bytes --]