* [PATCH] selftests: kselftest: Remove outdated comment
@ 2018-07-25 2:57 Thiago Jung Bauermann
2018-08-27 20:14 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Thiago Jung Bauermann @ 2018-07-25 2:57 UTC (permalink / raw)
To: linux-kselftest; +Cc: linux-kernel, Shuah Khan, Thiago Jung Bauermann
Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of
KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
change skip exit code to 0") but missed removing the comment which that
commit added, so do that now.
Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
---
tools/testing/selftests/kselftest.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
index 15e6b75fc3a5..a3edb2c8e43d 100644
--- a/tools/testing/selftests/kselftest.h
+++ b/tools/testing/selftests/kselftest.h
@@ -19,7 +19,6 @@
#define KSFT_FAIL 1
#define KSFT_XFAIL 2
#define KSFT_XPASS 3
-/* Treat skip as pass */
#define KSFT_SKIP 4
/* counters */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests: kselftest: Remove outdated comment
2018-07-25 2:57 [PATCH] selftests: kselftest: Remove outdated comment Thiago Jung Bauermann
@ 2018-08-27 20:14 ` Shuah Khan
2018-08-27 20:47 ` Thiago Jung Bauermann
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2018-08-27 20:14 UTC (permalink / raw)
To: Thiago Jung Bauermann, linux-kselftest; +Cc: linux-kernel, Shuah Khan
On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote:
> Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of
> KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
> change skip exit code to 0") but missed removing the comment which that
> commit added, so do that now.
>
> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
> ---
> tools/testing/selftests/kselftest.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index 15e6b75fc3a5..a3edb2c8e43d 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -19,7 +19,6 @@
> #define KSFT_FAIL 1
> #define KSFT_XFAIL 2
> #define KSFT_XPASS 3
> -/* Treat skip as pass */
> #define KSFT_SKIP 4
>
> /* counters */
>
>
Thanks for the patch. Sorry for the delay. It is now in linux-kselfttest
next for the next 4.19-rc
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] selftests: kselftest: Remove outdated comment
2018-08-27 20:14 ` Shuah Khan
@ 2018-08-27 20:47 ` Thiago Jung Bauermann
0 siblings, 0 replies; 3+ messages in thread
From: Thiago Jung Bauermann @ 2018-08-27 20:47 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kselftest, linux-kernel
Shuah Khan <shuah@kernel.org> writes:
> On 07/24/2018 08:57 PM, Thiago Jung Bauermann wrote:
>> Commit 3c07aaef6598 ("selftests: kselftest: change KSFT_SKIP=4 instead of
>> KSFT_PASS") reverted commit 11867a77eb85 ("selftests: kselftest framework:
>> change skip exit code to 0") but missed removing the comment which that
>> commit added, so do that now.
>>
>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>> ---
>> tools/testing/selftests/kselftest.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
>> index 15e6b75fc3a5..a3edb2c8e43d 100644
>> --- a/tools/testing/selftests/kselftest.h
>> +++ b/tools/testing/selftests/kselftest.h
>> @@ -19,7 +19,6 @@
>> #define KSFT_FAIL 1
>> #define KSFT_XFAIL 2
>> #define KSFT_XPASS 3
>> -/* Treat skip as pass */
>> #define KSFT_SKIP 4
>>
>> /* counters */
>>
>>
>
> Thanks for the patch. Sorry for the delay. It is now in linux-kselfttest
> next for the next 4.19-rc
The delay isn't a problem. Thanks!
--
Thiago Jung Bauermann
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-27 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 2:57 [PATCH] selftests: kselftest: Remove outdated comment Thiago Jung Bauermann
2018-08-27 20:14 ` Shuah Khan
2018-08-27 20:47 ` Thiago Jung Bauermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®