* [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py
@ 2018-07-28 14:48 Jeremy Cline
2018-07-29 2:11 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Cline @ 2018-07-28 14:48 UTC (permalink / raw)
To: Masahiro Yamada, Michal Marek
Cc: Frederic Weisbecker, linux-kbuild, linux-kernel, Jeremy Cline
Use the print function. This maintains Python 2 support and should have
no functional change.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
Changes from v1:
- Drop "from __future__ import print_function" as Python 2 is not long
for this world and in this case the statement and function behave
the same way.
scripts/tracing/draw_functrace.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
index db40fa04cd51..9b6dd4f36335 100755
--- a/scripts/tracing/draw_functrace.py
+++ b/scripts/tracing/draw_functrace.py
@@ -123,7 +123,7 @@ def main():
tree = tree.getParent(caller)
tree = tree.calls(callee, calltime)
- print CallTree.ROOT
+ print(CallTree.ROOT)
if __name__ == "__main__":
main()
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py
2018-07-28 14:48 [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py Jeremy Cline
@ 2018-07-29 2:11 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2018-07-29 2:11 UTC (permalink / raw)
To: Jeremy Cline
Cc: Michal Marek, Frederic Weisbecker, Linux Kbuild mailing list,
Linux Kernel Mailing List
2018-07-28 23:48 GMT+09:00 Jeremy Cline <jcline@redhat.com>:
> Use the print function. This maintains Python 2 support and should have
> no functional change.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
Applied to linux-kbuild. Thanks!
> Changes from v1:
> - Drop "from __future__ import print_function" as Python 2 is not long
> for this world and in this case the statement and function behave
> the same way.
>
> scripts/tracing/draw_functrace.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing/draw_functrace.py
> index db40fa04cd51..9b6dd4f36335 100755
> --- a/scripts/tracing/draw_functrace.py
> +++ b/scripts/tracing/draw_functrace.py
> @@ -123,7 +123,7 @@ def main():
> tree = tree.getParent(caller)
> tree = tree.calls(callee, calltime)
>
> - print CallTree.ROOT
> + print(CallTree.ROOT)
>
> if __name__ == "__main__":
> main()
> --
> 2.17.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-29 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-28 14:48 [PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py Jeremy Cline
2018-07-29 2:11 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®