* [PATCH 0/2] i2c: enable buses to save their clock frequency in adapter
@ 2018-08-01 13:35 Tudor Ambarus
2018-08-01 13:35 ` [PATCH 1/2] " Tudor Ambarus
2018-08-01 13:35 ` [PATCH 2/2] i2c: at91: Save the bus " Tudor Ambarus
0 siblings, 2 replies; 3+ messages in thread
From: Tudor Ambarus @ 2018-08-01 13:35 UTC (permalink / raw)
To: wsa, linux-i2c, ludovic.desroches, nicolas.ferre, alexandre.belloni
Cc: linux-kernel, linux-arm-kernel, linus.walleij, Tudor Ambarus
The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.
There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).
The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.
Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and enable the buses to save their clock frequency in adapter.
since rfc:
- reword commit messages
Tudor Ambarus (2):
i2c: enable buses to save their clock frequency in adapter
i2c: at91: Save the bus clock frequency in adapter
drivers/i2c/busses/i2c-at91.c | 1 +
include/linux/i2c.h | 1 +
2 files changed, 2 insertions(+)
--
2.9.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] i2c: enable buses to save their clock frequency in adapter
2018-08-01 13:35 [PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor Ambarus
@ 2018-08-01 13:35 ` Tudor Ambarus
2018-08-01 13:35 ` [PATCH 2/2] i2c: at91: Save the bus " Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2018-08-01 13:35 UTC (permalink / raw)
To: wsa, linux-i2c, ludovic.desroches, nicolas.ferre, alexandre.belloni
Cc: linux-kernel, linux-arm-kernel, linus.walleij, Tudor Ambarus
The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.
There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).
The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.
Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and enable the buses to save their clock frequency in adapter.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
include/linux/i2c.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index bc8d42f..fe65768 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -677,6 +677,7 @@ struct i2c_adapter {
struct rt_mutex bus_lock;
struct rt_mutex mux_lock;
+ u32 bus_freq_hz;
int timeout; /* in jiffies */
int retries;
struct device dev; /* the adapter device */
--
2.9.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] i2c: at91: Save the bus clock frequency in adapter
2018-08-01 13:35 [PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor Ambarus
2018-08-01 13:35 ` [PATCH 1/2] " Tudor Ambarus
@ 2018-08-01 13:35 ` Tudor Ambarus
1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2018-08-01 13:35 UTC (permalink / raw)
To: wsa, linux-i2c, ludovic.desroches, nicolas.ferre, alexandre.belloni
Cc: linux-kernel, linux-arm-kernel, linus.walleij, Tudor Ambarus
The clock-frequency property is not mandatory for the i2c buses. If it's
not present in the device tree, the buses __usually__ assume it's 100kHZ
(see altera, at91, axxia, etc.). Broadcom uses a 375kHZ default
clock-frequency, so the default clock frequency varies from bus to bus.
There are i2c clients that need to know the bus clock frequency in order to
compute their wake token (see atecc508a i2c client).
The clock-frequency value has to be propagated to the i2c clients, otherwise,
if they will not find the i2c bus clock frequency in the device tree, they
will have to make their own assumption of the clock frequency.
Spare the i2c clients of making wrong assumptions of the i2c bus clock
frequency and provide the bus clock frequency in adapter.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
---
drivers/i2c/busses/i2c-at91.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 3f3e8b3..9aa0937 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -1124,6 +1124,7 @@ static int at91_twi_probe(struct platform_device *pdev)
dev->adapter.quirks = &at91_twi_quirks;
dev->adapter.dev.parent = dev->dev;
dev->adapter.nr = pdev->id;
+ dev->adapter.bus_freq_hz = bus_clk_rate;
dev->adapter.timeout = AT91_I2C_TIMEOUT;
dev->adapter.dev.of_node = pdev->dev.of_node;
--
2.9.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 13:35 [PATCH 0/2] i2c: enable buses to save their clock frequency in adapter Tudor Ambarus
2018-08-01 13:35 ` [PATCH 1/2] " Tudor Ambarus
2018-08-01 13:35 ` [PATCH 2/2] i2c: at91: Save the bus " Tudor Ambarus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®