From: David Miller <davem@davemloft.net>
To: ndesaulniers@google.com
Cc: natechancellor@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr
Date: Thu, 02 Aug 2018 15:17:40 -0700 (PDT) [thread overview]
Message-ID: <20180802.151740.166085629835691260.davem@davemloft.net> (raw)
In-Reply-To: <CAKwvOdnp7R094sbsyKi921ZVB8BD+d-8L37mcPv0UjMMF4QqDg@mail.gmail.com>
From: Nick Desaulniers <ndesaulniers@google.com>
Date: Thu, 2 Aug 2018 15:10:00 -0700
> On Thu, Aug 2, 2018 at 2:42 PM David Miller <davem@davemloft.net> wrote:
>>
>> From: Nick Desaulniers <ndesaulniers@google.com>
>> Date: Wed, 1 Aug 2018 14:57:59 -0700
>>
>> > As part of the effort to reduce the code duplication between _THIS_IP_
>> > and current_text_addr(), let's consolidate callers of
>> > current_text_addr() to use _THIS_IP_.
>> >
>> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
>>
>> I'll ACk this for now:
>>
>> Acked-by: David S. Miller <davem@davemloft.net>
>
> Thank you David. Should you take it into the net tree, can you please add:
>
> Cc: stable@vger.kernel.org # 4.17, 4.14, 4.9, 4.4
>
> to the commit message? This will help us as Nathan stated previously
> in this thread.
Why in the world is this a stable candidate? It doesn't fix a bug.
My understanding is that you are trying to do a consolidation of code
and clean things up so that only one interface is used.
That means it should, at best, go to the net-next tree.
Thank you.
next prev parent reply other threads:[~2018-08-02 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 21:57 Nick Desaulniers
2018-08-02 1:42 ` David Miller
2018-08-02 4:58 ` Nathan Chancellor
2018-08-02 5:08 ` Nathan Chancellor
2018-08-02 17:07 ` Nick Desaulniers
2018-08-02 21:42 ` David Miller
2018-08-02 22:10 ` Nick Desaulniers
2018-08-02 22:17 ` David Miller [this message]
2018-08-02 22:29 ` Nick Desaulniers
2018-08-13 21:10 ` Nick Desaulniers
2018-08-14 17:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180802.151740.166085629835691260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®