* [PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory
@ 2018-08-02 13:47 Dirk Gouders
2018-08-02 15:48 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Dirk Gouders @ 2018-08-02 13:47 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Dirk Gouders, linux-kbuild, linux-kernel
The files auto.conf and tristate.conf are mandatory for building
modules.builtin files, therefore include them as such.
Usually, the top-level Makefile ensures that those files exist but we
want to make sure we get noticed if they are missing for whatever
reason.
Signed-off-by: Dirk Gouders <dirk@gouders.net>
---
scripts/Makefile.modbuiltin | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/Makefile.modbuiltin b/scripts/Makefile.modbuiltin
index 40867a41615b..a072a4267746 100644
--- a/scripts/Makefile.modbuiltin
+++ b/scripts/Makefile.modbuiltin
@@ -8,10 +8,10 @@ src := $(obj)
PHONY := __modbuiltin
__modbuiltin:
--include include/config/auto.conf
+include include/config/auto.conf
# tristate.conf sets tristate variables to uppercase 'Y' or 'M'
# That way, we get the list of built-in modules in obj-Y
--include include/config/tristate.conf
+include include/config/tristate.conf
include scripts/Kbuild.include
--
2.16.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory
2018-08-02 13:47 [PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory Dirk Gouders
@ 2018-08-02 15:48 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2018-08-02 15:48 UTC (permalink / raw)
To: Dirk Gouders; +Cc: Linux Kbuild mailing list, Linux Kernel Mailing List
2018-08-02 22:47 GMT+09:00 Dirk Gouders <dirk@gouders.net>:
> The files auto.conf and tristate.conf are mandatory for building
> modules.builtin files, therefore include them as such.
>
> Usually, the top-level Makefile ensures that those files exist but we
> want to make sure we get noticed if they are missing for whatever
> reason.
>
> Signed-off-by: Dirk Gouders <dirk@gouders.net>
> ---
Applied. Thanks!
> scripts/Makefile.modbuiltin | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/Makefile.modbuiltin b/scripts/Makefile.modbuiltin
> index 40867a41615b..a072a4267746 100644
> --- a/scripts/Makefile.modbuiltin
> +++ b/scripts/Makefile.modbuiltin
> @@ -8,10 +8,10 @@ src := $(obj)
> PHONY := __modbuiltin
> __modbuiltin:
>
> --include include/config/auto.conf
> +include include/config/auto.conf
> # tristate.conf sets tristate variables to uppercase 'Y' or 'M'
> # That way, we get the list of built-in modules in obj-Y
> --include include/config/tristate.conf
> +include include/config/tristate.conf
>
> include scripts/Kbuild.include
>
> --
> 2.16.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-02 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 13:47 [PATCH] Kbuild: Makefile.modbuiltin: include auto.conf and tristate.conf mandatory Dirk Gouders
2018-08-02 15:48 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®