* [PATCH] lightnvm: remove minor version check for 2.0
@ 2018-08-03 9:02 Matias Bjørling
2018-08-03 12:07 ` Javier Gonzalez
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjørling @ 2018-08-03 9:02 UTC (permalink / raw)
To: igor.j.konopko, marcin.dziegielewski, javier, hans.holmberg,
hlitz, youngtack.jin
Cc: linux-block, linux-kernel, Matias Bjørling
A minor version number increase should not break backwards
compatibility.
Fixes: 3cb98f84d368b ("lightnvm: add minor version to generic geometry")
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
drivers/nvme/host/lightnvm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index d9e4cccd5b66..a156fe3ca7d3 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -414,12 +414,6 @@ static int nvme_nvm_setup_20(struct nvme_nvm_id20 *id,
/* Set compacted version for upper layers */
geo->version = NVM_OCSSD_SPEC_20;
- if (!(geo->major_ver_id == 2 && geo->minor_ver_id == 0)) {
- pr_err("nvm: OCSSD version not supported (v%d.%d)\n",
- geo->major_ver_id, geo->minor_ver_id);
- return -EINVAL;
- }
-
geo->num_ch = le16_to_cpu(id->num_grp);
geo->num_lun = le16_to_cpu(id->num_pu);
geo->all_luns = geo->num_ch * geo->num_lun;
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] lightnvm: remove minor version check for 2.0
2018-08-03 9:02 [PATCH] lightnvm: remove minor version check for 2.0 Matias Bjørling
@ 2018-08-03 12:07 ` Javier Gonzalez
2018-08-05 8:29 ` Matias Bjørling
0 siblings, 1 reply; 4+ messages in thread
From: Javier Gonzalez @ 2018-08-03 12:07 UTC (permalink / raw)
To: Matias Bjørling
Cc: Konopko, Igor J, marcin.dziegielewski, Hans Holmberg,
Heiner Litz, Young Tack Tack Jin, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
> On 3 Aug 2018, at 11.02, Matias Bjørling <mb@lightnvm.io> wrote:
>
> A minor version number increase should not break backwards
> compatibility.
>
> Fixes: 3cb98f84d368b ("lightnvm: add minor version to generic geometry")
> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
> ---
> drivers/nvme/host/lightnvm.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index d9e4cccd5b66..a156fe3ca7d3 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -414,12 +414,6 @@ static int nvme_nvm_setup_20(struct nvme_nvm_id20 *id,
> /* Set compacted version for upper layers */
> geo->version = NVM_OCSSD_SPEC_20;
>
> - if (!(geo->major_ver_id == 2 && geo->minor_ver_id == 0)) {
> - pr_err("nvm: OCSSD version not supported (v%d.%d)\n",
> - geo->major_ver_id, geo->minor_ver_id);
> - return -EINVAL;
> - }
> -
> geo->num_ch = le16_to_cpu(id->num_grp);
> geo->num_lun = le16_to_cpu(id->num_pu);
> geo->all_luns = geo->num_ch * geo->num_lun;
> --
> 2.11.0
Looks good to me.
Reviewed-by: Javier González <javier@cnexlabs.com>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] lightnvm: remove minor version check for 2.0
2018-08-03 12:07 ` Javier Gonzalez
@ 2018-08-05 8:29 ` Matias Bjørling
2018-08-05 14:26 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Matias Bjørling @ 2018-08-05 8:29 UTC (permalink / raw)
To: axboe
Cc: Javier Gonzalez, Konopko, Igor J, marcin.dziegielewski,
Hans Holmberg, Heiner Litz, Young Tack Tack Jin, linux-block,
linux-kernel
On 8/3/18 2:07 PM, Javier Gonzalez wrote:
>> On 3 Aug 2018, at 11.02, Matias Bjørling <mb@lightnvm.io> wrote:
>>
>> A minor version number increase should not break backwards
>> compatibility.
>>
>> Fixes: 3cb98f84d368b ("lightnvm: add minor version to generic geometry")
>> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
>> ---
>> drivers/nvme/host/lightnvm.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
>> index d9e4cccd5b66..a156fe3ca7d3 100644
>> --- a/drivers/nvme/host/lightnvm.c
>> +++ b/drivers/nvme/host/lightnvm.c
>> @@ -414,12 +414,6 @@ static int nvme_nvm_setup_20(struct nvme_nvm_id20 *id,
>> /* Set compacted version for upper layers */
>> geo->version = NVM_OCSSD_SPEC_20;
>>
>> - if (!(geo->major_ver_id == 2 && geo->minor_ver_id == 0)) {
>> - pr_err("nvm: OCSSD version not supported (v%d.%d)\n",
>> - geo->major_ver_id, geo->minor_ver_id);
>> - return -EINVAL;
>> - }
>> -
>> geo->num_ch = le16_to_cpu(id->num_grp);
>> geo->num_lun = le16_to_cpu(id->num_pu);
>> geo->all_luns = geo->num_ch * geo->num_lun;
>> --
>> 2.11.0
>
> Looks good to me.
>
> Reviewed-by: Javier González <javier@cnexlabs.com>
>
Hi Jens,
Would it be possible to pick this one up for 4.19?
Thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] lightnvm: remove minor version check for 2.0
2018-08-05 8:29 ` Matias Bjørling
@ 2018-08-05 14:26 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2018-08-05 14:26 UTC (permalink / raw)
To: Matias Bjørling
Cc: Javier Gonzalez, Konopko, Igor J, marcin.dziegielewski,
Hans Holmberg, Heiner Litz, Young Tack Tack Jin, linux-block,
linux-kernel
On 8/5/18 2:29 AM, Matias Bjørling wrote:
> On 8/3/18 2:07 PM, Javier Gonzalez wrote:
>>> On 3 Aug 2018, at 11.02, Matias Bjørling <mb@lightnvm.io> wrote:
>>>
>>> A minor version number increase should not break backwards
>>> compatibility.
>>>
>>> Fixes: 3cb98f84d368b ("lightnvm: add minor version to generic geometry")
>>> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
>>> ---
>>> drivers/nvme/host/lightnvm.c | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
>>> index d9e4cccd5b66..a156fe3ca7d3 100644
>>> --- a/drivers/nvme/host/lightnvm.c
>>> +++ b/drivers/nvme/host/lightnvm.c
>>> @@ -414,12 +414,6 @@ static int nvme_nvm_setup_20(struct nvme_nvm_id20 *id,
>>> /* Set compacted version for upper layers */
>>> geo->version = NVM_OCSSD_SPEC_20;
>>>
>>> - if (!(geo->major_ver_id == 2 && geo->minor_ver_id == 0)) {
>>> - pr_err("nvm: OCSSD version not supported (v%d.%d)\n",
>>> - geo->major_ver_id, geo->minor_ver_id);
>>> - return -EINVAL;
>>> - }
>>> -
>>> geo->num_ch = le16_to_cpu(id->num_grp);
>>> geo->num_lun = le16_to_cpu(id->num_pu);
>>> geo->all_luns = geo->num_ch * geo->num_lun;
>>> --
>>> 2.11.0
>>
>> Looks good to me.
>>
>> Reviewed-by: Javier González <javier@cnexlabs.com>
>>
>
> Hi Jens,
>
> Would it be possible to pick this one up for 4.19?
Done.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-05 14:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-03 9:02 [PATCH] lightnvm: remove minor version check for 2.0 Matias Bjørling
2018-08-03 12:07 ` Javier Gonzalez
2018-08-05 8:29 ` Matias Bjørling
2018-08-05 14:26 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®