* [PATCH 1/3] pinctrl: madera: Set is_generic
@ 2018-08-07 9:32 Richard Fitzgerald
2018-08-07 9:32 ` [PATCH 2/3] pinctrl: madera: Return ENOTSUPP for unsupported pin attributes Richard Fitzgerald
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Richard Fitzgerald @ 2018-08-07 9:32 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-kernel, linux-gpio, patches, Richard Fitzgerald
We are using the generic pin configuration interface so
we can set is_generic.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
drivers/pinctrl/cirrus/pinctrl-madera-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
index ece41fb2848f..4f9b7e3b7cf2 100644
--- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
+++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
@@ -971,10 +971,10 @@ static int madera_pin_conf_group_set(struct pinctrl_dev *pctldev,
}
static const struct pinconf_ops madera_pin_conf_ops = {
+ .is_generic = true,
.pin_config_get = madera_pin_conf_get,
.pin_config_set = madera_pin_conf_set,
.pin_config_group_set = madera_pin_conf_group_set,
-
};
static struct pinctrl_desc madera_pin_desc = {
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/3] pinctrl: madera: Return ENOTSUPP for unsupported pin attributes
2018-08-07 9:32 [PATCH 1/3] pinctrl: madera: Set is_generic Richard Fitzgerald
@ 2018-08-07 9:32 ` Richard Fitzgerald
2018-08-29 8:42 ` Linus Walleij
2018-08-07 9:32 ` [PATCH 3/3] pinctrl: madera: Fix missing space in debugfs output Richard Fitzgerald
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Richard Fitzgerald @ 2018-08-07 9:32 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-kernel, linux-gpio, patches, Richard Fitzgerald
The pin_config_[get|set] functions should return ENOTSUPP if
the requested attribute isn't supported.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
drivers/pinctrl/cirrus/pinctrl-madera-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
index 4f9b7e3b7cf2..4ba56ca5a9be 100644
--- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
+++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
@@ -801,7 +801,7 @@ static int madera_pin_conf_get(struct pinctrl_dev *pctldev, unsigned int pin,
result = 1;
break;
default:
- break;
+ return -ENOTSUPP;
}
*config = pinconf_to_config_packed(param, result);
@@ -905,7 +905,7 @@ static int madera_pin_conf_set(struct pinctrl_dev *pctldev, unsigned int pin,
conf[1] &= ~MADERA_GP1_DIR;
break;
default:
- break;
+ return -ENOTSUPP;
}
++configs;
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/3] pinctrl: madera: Fix missing space in debugfs output
2018-08-07 9:32 [PATCH 1/3] pinctrl: madera: Set is_generic Richard Fitzgerald
2018-08-07 9:32 ` [PATCH 2/3] pinctrl: madera: Return ENOTSUPP for unsupported pin attributes Richard Fitzgerald
@ 2018-08-07 9:32 ` Richard Fitzgerald
2018-08-29 8:44 ` Linus Walleij
2018-08-10 21:10 ` [PATCH 1/3] pinctrl: madera: Set is_generic Linus Walleij
2018-08-29 8:41 ` Linus Walleij
3 siblings, 1 reply; 7+ messages in thread
From: Richard Fitzgerald @ 2018-08-07 9:32 UTC (permalink / raw)
To: linus.walleij; +Cc: linux-kernel, linux-gpio, patches, Richard Fitzgerald
The SCHMITT tag was being dumped without a separating space.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
drivers/pinctrl/cirrus/pinctrl-madera-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
index 4ba56ca5a9be..979df109e187 100644
--- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c
+++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c
@@ -550,7 +550,7 @@ static void __maybe_unused madera_pin_dbg_show(struct pinctrl_dev *pctldev,
seq_printf(s, " DRV=%umA", madera_pin_unmake_drv_str(priv, conf[1]));
if (conf[0] & MADERA_GP1_IP_CFG_MASK)
- seq_puts(s, "SCHMITT");
+ seq_puts(s, " SCHMITT");
}
--
2.11.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] pinctrl: madera: Set is_generic
2018-08-07 9:32 [PATCH 1/3] pinctrl: madera: Set is_generic Richard Fitzgerald
2018-08-07 9:32 ` [PATCH 2/3] pinctrl: madera: Return ENOTSUPP for unsupported pin attributes Richard Fitzgerald
2018-08-07 9:32 ` [PATCH 3/3] pinctrl: madera: Fix missing space in debugfs output Richard Fitzgerald
@ 2018-08-10 21:10 ` Linus Walleij
2018-08-29 8:41 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-08-10 21:10 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: linux-kernel, open list:GPIO SUBSYSTEM, patches
On Tue, Aug 7, 2018 at 11:32 AM Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
> We are using the generic pin configuration interface so
> we can set is_generic.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
For these patches.
This is not yet in my tree, but I can apply this and the others
after -rc1 (probably the easiest).
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] pinctrl: madera: Set is_generic
2018-08-07 9:32 [PATCH 1/3] pinctrl: madera: Set is_generic Richard Fitzgerald
` (2 preceding siblings ...)
2018-08-10 21:10 ` [PATCH 1/3] pinctrl: madera: Set is_generic Linus Walleij
@ 2018-08-29 8:41 ` Linus Walleij
3 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2018-08-29 8:41 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: linux-kernel, open list:GPIO SUBSYSTEM, patches
On Tue, Aug 7, 2018 at 11:32 AM Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
> We are using the generic pin configuration interface so
> we can set is_generic.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Patch applied for v4.20.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-29 8:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-07 9:32 [PATCH 1/3] pinctrl: madera: Set is_generic Richard Fitzgerald
2018-08-07 9:32 ` [PATCH 2/3] pinctrl: madera: Return ENOTSUPP for unsupported pin attributes Richard Fitzgerald
2018-08-29 8:42 ` Linus Walleij
2018-08-07 9:32 ` [PATCH 3/3] pinctrl: madera: Fix missing space in debugfs output Richard Fitzgerald
2018-08-29 8:44 ` Linus Walleij
2018-08-10 21:10 ` [PATCH 1/3] pinctrl: madera: Set is_generic Linus Walleij
2018-08-29 8:41 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome