From: Steven Rostedt <rostedt@goodmis.org>
To: Colin King <colin.king@canonical.com>
Cc: Ingo Molnar <mingo@redhat.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ftrace: remove unused pointer ftrace_swapper_pid
Date: Thu, 9 Aug 2018 10:18:42 -0400 [thread overview]
Message-ID: <20180809101842.5994fd21@gandalf.local.home> (raw)
In-Reply-To: <20180809125609.13142-1-colin.king@canonical.com>
On Thu, 9 Aug 2018 13:56:09 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer ftrace_swapper_pid is defined but is never used hence it is
> redundant and can be removed. The use of this variable was removed
> in commit 345ddcc882d8 ("ftrace: Have set_ftrace_pid use the bitmap
> like events do").
>
> Cleans up clang warning:
> warning: 'ftrace_swapper_pid' defined but not used [-Wunused-const-variable=]
Thanks, applied!
-- Steve
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/trace/ftrace.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index caf9cbf35816..2cc008cfbd4f 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -1049,8 +1049,6 @@ static __init void ftrace_profile_tracefs(struct dentry *d_tracer)
> }
> #endif /* CONFIG_FUNCTION_PROFILER */
>
> -static struct pid * const ftrace_swapper_pid = &init_struct_pid;
> -
> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
> static int ftrace_graph_active;
> #else
prev parent reply other threads:[~2018-08-09 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 12:56 Colin King
2018-08-09 14:18 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809101842.5994fd21@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®