From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: <linux-mmc@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Cc: <ulf.hansson@linaro.org>, <linux-kernel@vger.kernel.org>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<dgilbert@interlog.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: [PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18
Date: Mon, 20 Aug 2018 10:54:43 +0200 [thread overview]
Message-ID: <20180820085445.14632-1-ludovic.desroches@microchip.com> (raw)
Hi,
Dougas Gilbert noticed that atmel-mci was broken with the 4.18 release.
He found the culprit commit which is 5b4277814e3fd
("[PATCH 2/7] mmc: atmel-mci: use sg_copy_{from,to}_buffer"). The from/to
logic was inverted: sg_copy_to_buffer copies from an SG list to a linear
buffer so it can't replace a memcpy where the destination is the virtual
address of an SG buffer.
This patch was part of "make more host drivers highmem safe v2". It seems
there is the same logical error within the android-goldfish driver but I
couldn't check it on real hardware.
Ludovic Desroches (2):
mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion
mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer
conversion
drivers/mmc/host/android-goldfish.c | 4 ++--
drivers/mmc/host/atmel-mci.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
--
2.12.2
next reply other threads:[~2018-08-20 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 8:54 Ludovic Desroches [this message]
2018-08-20 8:54 ` [PATCH 1/2] mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion Ludovic Desroches
2018-08-20 8:54 ` [PATCH 2/2] mmc: android-goldfish: " Ludovic Desroches
2018-08-21 14:19 ` [PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820085445.14632-1-ludovic.desroches@microchip.com \
--to=ludovic.desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dgilbert@interlog.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®