* [PATCH] ACPI: fix menuconfig presentation of ACPI submenu
@ 2018-08-21 20:37 Arnd Bergmann
2018-08-23 8:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-08-21 20:37 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: Ard Biesheuvel, Arnd Bergmann, Will Deacon, Thomas Gleixner,
linux-acpi, linux-kernel
My fix for a recursive Kconfig dependency caused another issue where the
ACPI specific options end up in the top-level menu in 'menuconfig'. This
was an unintended side-effect of having a silent option between
'menuconfig ACPI' and 'if ACPI'.
Moving the ARCH_SUPPORTS_ACPI symbol ahead of the ACPI menu solves that
problem and restores the previous presentation.
Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Fixes: 2c870e61132c ("arm64: fix ACPI dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/acpi/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 1edca05ee0ae..e92eab1e960c 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -3,6 +3,9 @@
# ACPI Configuration
#
+config ARCH_SUPPORTS_ACPI
+ bool
+
menuconfig ACPI
bool "ACPI (Advanced Configuration and Power Interface) Support"
depends on ARCH_SUPPORTS_ACPI
@@ -40,9 +43,6 @@ menuconfig ACPI
<http://www.acpi.info>
<http://www.uefi.org/acpi/specs>
-config ARCH_SUPPORTS_ACPI
- bool
-
if ACPI
config ACPI_LEGACY_TABLES_LOOKUP
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ACPI: fix menuconfig presentation of ACPI submenu
2018-08-21 20:37 [PATCH] ACPI: fix menuconfig presentation of ACPI submenu Arnd Bergmann
@ 2018-08-23 8:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2018-08-23 8:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Rafael J. Wysocki, Len Brown, Ard Biesheuvel, Will Deacon,
Thomas Gleixner, ACPI Devel Maling List,
Linux Kernel Mailing List
On Tue, Aug 21, 2018 at 10:38 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> My fix for a recursive Kconfig dependency caused another issue where the
> ACPI specific options end up in the top-level menu in 'menuconfig'. This
> was an unintended side-effect of having a silent option between
> 'menuconfig ACPI' and 'if ACPI'.
>
> Moving the ARCH_SUPPORTS_ACPI symbol ahead of the ACPI menu solves that
> problem and restores the previous presentation.
>
> Reported-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Fixes: 2c870e61132c ("arm64: fix ACPI dependencies")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks!
I'll push this to Linus tomorrow.
> ---
> drivers/acpi/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index 1edca05ee0ae..e92eab1e960c 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -3,6 +3,9 @@
> # ACPI Configuration
> #
>
> +config ARCH_SUPPORTS_ACPI
> + bool
> +
> menuconfig ACPI
> bool "ACPI (Advanced Configuration and Power Interface) Support"
> depends on ARCH_SUPPORTS_ACPI
> @@ -40,9 +43,6 @@ menuconfig ACPI
> <http://www.acpi.info>
> <http://www.uefi.org/acpi/specs>
>
> -config ARCH_SUPPORTS_ACPI
> - bool
> -
> if ACPI
>
> config ACPI_LEGACY_TABLES_LOOKUP
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-23 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-21 20:37 [PATCH] ACPI: fix menuconfig presentation of ACPI submenu Arnd Bergmann
2018-08-23 8:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®