From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 02/21] staging:rtl8192u: Refactor RT_RF_TYPE_DEF - Style
Date: Sun, 26 Aug 2018 22:14:20 +0100 [thread overview]
Message-ID: <20180826211439.14326-3-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180826211439.14326-1-johnfwhitmore@gmail.com>
Rename the enumerated type RT_RF_TYPE_DEF to rt_rf_type to comply
with the coding standard, lower case type names. Removed the 'def'
postscript which provides no additional information.
The 'typedef' directive has been removed to clear the checkpatch issue
with defining new types.
The type has been moved to the file r8192U.h, where it is
actually used by the member variable 'rf_type'. Previously the member
variable used a 'u8' type so no compiler type checking is being
performed. The type has been changed to the correct type.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r8192U.h | 8 +++++++-
drivers/staging/rtl8192u/r8192U_hw.h | 9 ---------
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
index ce287e2f79e1..1b51601df1ee 100644
--- a/drivers/staging/rtl8192u/r8192U.h
+++ b/drivers/staging/rtl8192u/r8192U.h
@@ -804,6 +804,12 @@ enum version_819xu {
VERSION_819XU_C,// C-cut
};
+//added for different RF type
+enum rt_rf_type {
+ RF_1T2R = 0,
+ RF_2T4R,
+};
+
typedef struct r8192_priv {
struct usb_device *udev;
/* For maintain info from eeprom */
@@ -844,7 +850,7 @@ typedef struct r8192_priv {
struct mutex wx_mutex;
- u8 rf_type; /* 0: 1T2R, 1: 2T4R */
+ enum rt_rf_type rf_type; /* 0: 1T2R, 1: 2T4R */
RT_RF_TYPE_819xU rf_chip;
short (*rf_set_sens)(struct net_device *dev, short sens);
diff --git a/drivers/staging/rtl8192u/r8192U_hw.h b/drivers/staging/rtl8192u/r8192U_hw.h
index 15e56003d97c..f91dd20fa568 100644
--- a/drivers/staging/rtl8192u/r8192U_hw.h
+++ b/drivers/staging/rtl8192u/r8192U_hw.h
@@ -20,15 +20,6 @@
#ifndef R8192_HW
#define R8192_HW
-//added for different RF type
-typedef enum _RT_RF_TYPE_DEF {
- RF_1T2R = 0,
- RF_2T4R,
-
- RF_819X_MAX_TYPE
-} RT_RF_TYPE_DEF;
-
-
typedef enum _BaseBand_Config_Type {
BaseBand_Config_PHY_REG = 0, //Radio Path A
BaseBand_Config_AGC_TAB = 1, //Radio Path B
--
2.18.0
next prev parent reply other threads:[~2018-08-26 21:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 21:14 [PATCH 00/21] staging:rtl8192u: r8192U_hw.h " John Whitmore
2018-08-26 21:14 ` [PATCH 01/21] staging:rtl8192u: Refactor enum VERSION_819xU " John Whitmore
2018-08-26 21:14 ` John Whitmore [this message]
2018-08-26 21:14 ` [PATCH 03/21] staging:rtl8192u: Make function rtl8192_phyConfigBB static John Whitmore
2018-08-26 21:14 ` [PATCH 04/21] staging:rtl8192u: Refactor BaseBand_Config_Type - Style John Whitmore
2018-08-26 21:14 ` [PATCH 05/21] staging:rtl8192u: Remove unused definitions " John Whitmore
2018-08-26 21:14 ` [PATCH 06/21] staging:rtl8192u: Reorder enum _RTL8192Usb_HW members " John Whitmore
2018-08-26 21:14 ` [PATCH 07/21] staging:rtl8192u: Rename EEPROM_TxPowerDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 08/21] staging:rtl8192u: Rename EEPROM_ThermalMeter " John Whitmore
2018-08-26 21:14 ` [PATCH 09/21] staging:rtl8192u: Rename EEPROM_PwDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 10/21] staging:rtl8192u: Rename EEPROM_CrystalCap " John Whitmore
2018-08-26 21:14 ` [PATCH 11/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_CCK " John Whitmore
2018-08-26 21:14 ` [PATCH 12/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_OFDM_24G_V1 - STYLE John Whitmore
2018-08-26 21:14 ` [PATCH 13/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_OFDM_24G - Style John Whitmore
2018-08-26 21:14 ` [PATCH 14/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_CCK_V1 " John Whitmore
2018-08-26 21:14 ` [PATCH 15/21] staging:rtl8192u: rename EEPROM_TxPwIndex_Ver " John Whitmore
2018-08-26 21:14 ` [PATCH 16/21] staging:rtl8192u: Rename EEPROM_Default_ThermalMeter " John Whitmore
2018-08-26 21:14 ` [PATCH 17/21] staging:rtl8192u: Rename EEPROM_Default_PwDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 18/21] staging:rtl8192u: Rename EEPROM_Default_CrystalCap " John Whitmore
2018-08-26 21:14 ` [PATCH 19/21] staging:rtl8192u: Rename EEPROM_Default_TxPower " John Whitmore
2018-08-26 21:14 ` [PATCH 20/21] staging:rtl8192u: Rename EEPROM_Customer_ID " John Whitmore
2018-08-26 21:14 ` [PATCH 21/21] staging:rtl8192u: Rename EEPROM_ChannelPlan " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180826211439.14326-3-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®