From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 03/21] staging:rtl8192u: Make function rtl8192_phyConfigBB static
Date: Sun, 26 Aug 2018 22:14:21 +0100 [thread overview]
Message-ID: <20180826211439.14326-4-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180826211439.14326-1-johnfwhitmore@gmail.com>
The function rtl8192_phyConfigBB is only used in the file in which it
is defined so can be declared static. Additionally the prototype has
been removed from the header file, as it is not used.
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/r819xU_phy.c | 2 +-
drivers/staging/rtl8192u/r819xU_phy.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
index 8e6ed20848d8..a6d7ad1f6d79 100644
--- a/drivers/staging/rtl8192u/r819xU_phy.c
+++ b/drivers/staging/rtl8192u/r819xU_phy.c
@@ -511,7 +511,7 @@ void rtl8192_phy_configmac(struct net_device *dev)
* notice: BB parameters may change all the time, so please make
* sure it has been synced with the newest.
*****************************************************************************/
-void rtl8192_phyConfigBB(struct net_device *dev, u8 ConfigType)
+static void rtl8192_phyConfigBB(struct net_device *dev, u8 ConfigType)
{
u32 i;
diff --git a/drivers/staging/rtl8192u/r819xU_phy.h b/drivers/staging/rtl8192u/r819xU_phy.h
index c7ec3182857f..c938fd8eb51c 100644
--- a/drivers/staging/rtl8192u/r819xU_phy.h
+++ b/drivers/staging/rtl8192u/r819xU_phy.h
@@ -52,7 +52,6 @@ u32 rtl8192_phy_QueryRFReg(struct net_device *dev,
enum rf90_radio_path_e e_rfpath,
u32 reg_addr, u32 bitmask);
void rtl8192_phy_configmac(struct net_device *dev);
-void rtl8192_phyConfigBB(struct net_device *dev, u8 ConfigType);
u8 rtl8192_phy_checkBBAndRF(struct net_device *dev,
enum hw90_block_e CheckBlock,
enum rf90_radio_path_e e_rfpath);
--
2.18.0
next prev parent reply other threads:[~2018-08-26 21:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-26 21:14 [PATCH 00/21] staging:rtl8192u: r8192U_hw.h - Style John Whitmore
2018-08-26 21:14 ` [PATCH 01/21] staging:rtl8192u: Refactor enum VERSION_819xU " John Whitmore
2018-08-26 21:14 ` [PATCH 02/21] staging:rtl8192u: Refactor RT_RF_TYPE_DEF " John Whitmore
2018-08-26 21:14 ` John Whitmore [this message]
2018-08-26 21:14 ` [PATCH 04/21] staging:rtl8192u: Refactor BaseBand_Config_Type " John Whitmore
2018-08-26 21:14 ` [PATCH 05/21] staging:rtl8192u: Remove unused definitions " John Whitmore
2018-08-26 21:14 ` [PATCH 06/21] staging:rtl8192u: Reorder enum _RTL8192Usb_HW members " John Whitmore
2018-08-26 21:14 ` [PATCH 07/21] staging:rtl8192u: Rename EEPROM_TxPowerDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 08/21] staging:rtl8192u: Rename EEPROM_ThermalMeter " John Whitmore
2018-08-26 21:14 ` [PATCH 09/21] staging:rtl8192u: Rename EEPROM_PwDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 10/21] staging:rtl8192u: Rename EEPROM_CrystalCap " John Whitmore
2018-08-26 21:14 ` [PATCH 11/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_CCK " John Whitmore
2018-08-26 21:14 ` [PATCH 12/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_OFDM_24G_V1 - STYLE John Whitmore
2018-08-26 21:14 ` [PATCH 13/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_OFDM_24G - Style John Whitmore
2018-08-26 21:14 ` [PATCH 14/21] staging:rtl8192u: Rename EEPROM_TxPwIndex_CCK_V1 " John Whitmore
2018-08-26 21:14 ` [PATCH 15/21] staging:rtl8192u: rename EEPROM_TxPwIndex_Ver " John Whitmore
2018-08-26 21:14 ` [PATCH 16/21] staging:rtl8192u: Rename EEPROM_Default_ThermalMeter " John Whitmore
2018-08-26 21:14 ` [PATCH 17/21] staging:rtl8192u: Rename EEPROM_Default_PwDiff " John Whitmore
2018-08-26 21:14 ` [PATCH 18/21] staging:rtl8192u: Rename EEPROM_Default_CrystalCap " John Whitmore
2018-08-26 21:14 ` [PATCH 19/21] staging:rtl8192u: Rename EEPROM_Default_TxPower " John Whitmore
2018-08-26 21:14 ` [PATCH 20/21] staging:rtl8192u: Rename EEPROM_Customer_ID " John Whitmore
2018-08-26 21:14 ` [PATCH 21/21] staging:rtl8192u: Rename EEPROM_ChannelPlan " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180826211439.14326-4-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®