* [PATCH] phy: phy-twl4030-usb: fix denied runtime access
@ 2018-08-27 19:48 Andreas Kemnade
0 siblings, 0 replies; only message in thread
From: Andreas Kemnade @ 2018-08-27 19:48 UTC (permalink / raw)
To: kishon, lee.jones, dmitry.torokhov, daniel.thompson, wsa,
linux-omap, linux-kernel, Discussions about the Letux Kernel
Cc: Andreas Kemnade
When runtime is not enabled, pm_runtime_get_sync() returns -EACCESS,
the counter will be incremented but the resume callback not called,
so enumeration and charging will not start properly.
To avoid that happen, wait and try again later.
Practically this happens when the device is woken up from suspend by
plugging in usb.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/phy/ti/phy-twl4030-usb.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/phy/ti/phy-twl4030-usb.c b/drivers/phy/ti/phy-twl4030-usb.c
index a44680d64f9b..1f3cf4e48383 100644
--- a/drivers/phy/ti/phy-twl4030-usb.c
+++ b/drivers/phy/ti/phy-twl4030-usb.c
@@ -552,6 +552,15 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
status = twl4030_usb_linkstat(twl);
+ /* we might get here too early when runtime is not ready yet
+ * and we will get an EACCESS later, so try again later
+ */
+ if (!pm_runtime_enabled(twl->dev)) {
+ cancel_delayed_work(&twl->id_workaround_work);
+ schedule_delayed_work(&twl->id_workaround_work, HZ);
+ return IRQ_HANDLED;
+ }
+
mutex_lock(&twl->lock);
if (status >= 0 && status != twl->linkstat) {
status_changed =
--
2.11.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-08-27 19:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 19:48 [PATCH] phy: phy-twl4030-usb: fix denied runtime access Andreas Kemnade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®