* [PATCH] ipmi: msghandler: ensure error value in rv is being returned on error
@ 2018-08-28 14:36 Colin King
2018-08-28 15:01 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-08-28 14:36 UTC (permalink / raw)
To: Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman, openipmi-developer
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently ipmi_set_my_LUN returns 0 instead of -EINVAL if the channel
is out of range. Fix this by returning the error return rv instead of 0.
Detected by Clang ("variable 'rv' set but not used")
Fixes: 048f7c3e352e ("ipmi: Properly release srcu locks on error conditions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 04f64c55e275..a74ce885b541 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -1344,7 +1344,7 @@ int ipmi_set_my_LUN(struct ipmi_user *user,
user->intf->addrinfo[channel].lun = LUN & 0x3;
release_ipmi_user(user, index);
- return 0;
+ return rv;
}
EXPORT_SYMBOL(ipmi_set_my_LUN);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ipmi: msghandler: ensure error value in rv is being returned on error
2018-08-28 14:36 [PATCH] ipmi: msghandler: ensure error value in rv is being returned on error Colin King
@ 2018-08-28 15:01 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2018-08-28 15:01 UTC (permalink / raw)
To: Colin King
Cc: Corey Minyard, Arnd Bergmann, Greg Kroah-Hartman,
openipmi-developer, kernel-janitors, linux-kernel
On Tue, Aug 28, 2018 at 03:36:42PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently ipmi_set_my_LUN returns 0 instead of -EINVAL if the channel
> is out of range. Fix this by returning the error return rv instead of 0.
>
> Detected by Clang ("variable 'rv' set but not used")
>
> Fixes: 048f7c3e352e ("ipmi: Properly release srcu locks on error conditions")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Somebody just sent that some hours ago.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-28 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 14:36 [PATCH] ipmi: msghandler: ensure error value in rv is being returned on error Colin King
2018-08-28 15:01 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®