From: David Miller <davem@davemloft.net>
To: igor.stoppa@gmail.com
Cc: huangdaode@hisilicon.com, igor.stoppa@huawei.com,
yisen.zhuang@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet: hnae: add unlikely() to assert()
Date: Fri, 07 Sep 2018 14:46:59 -0700 (PDT) [thread overview]
Message-ID: <20180907.144659.284526279757617907.davem@davemloft.net> (raw)
In-Reply-To: <20180907172650.29408-1-igor.stoppa@huawei.com>
From: Igor Stoppa <igor.stoppa@gmail.com>
Date: Fri, 7 Sep 2018 20:26:50 +0300
> The assert() condition is likely to be true.
Worse than that is that drivers should not be definiting their own
private "assert()" macro.
I'd rather have that fixed instead. We have tons of standard kernel
facilities that do what they are trying to do here, without overloading
the standard C namespace in this way.
next prev parent reply other threads:[~2018-09-07 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 17:26 Igor Stoppa
2018-09-07 21:46 ` David Miller [this message]
2018-09-08 15:00 ` Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907.144659.284526279757617907.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=igor.stoppa@gmail.com \
--cc=igor.stoppa@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®