From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] printk/tracing: Do not trace printk_nmi_enter()
Date: Fri, 7 Sep 2018 09:55:33 -0400 [thread overview]
Message-ID: <20180907095533.5b5febc2@gandalf.local.home> (raw)
In-Reply-To: <20180907134532.GD24106@hirez.programming.kicks-ass.net>
On Fri, 7 Sep 2018 15:45:32 +0200
Peter Zijlstra <peterz@infradead.org> wrote:
> Yes really, we should not muck with the IRQ state from NMI context.
Right, and we didn't. Your patch didn't change anything, but allow for
printk_nmi_enter/exit() to be traced by ftrace, but that's wrong to
begin with because it ftrace_nmi_enter() hasn't been called yet.
-- Steve
next prev parent reply other threads:[~2018-09-07 13:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 1:33 Steven Rostedt
2018-09-06 2:31 ` Sergey Senozhatsky
2018-09-06 9:04 ` Petr Mladek
2018-09-06 15:22 ` Steven Rostedt
2018-09-07 7:45 ` Peter Zijlstra
2018-09-07 8:28 ` Petr Mladek
2018-09-07 8:35 ` Sergey Senozhatsky
2018-09-07 13:47 ` Steven Rostedt
2018-09-07 9:30 ` Peter Zijlstra
2018-09-07 13:53 ` Steven Rostedt
2018-09-10 5:32 ` locking/lockdep: Fix NMI handling kbuild test robot
2018-09-07 7:34 ` [PATCH] printk/tracing: Do not trace printk_nmi_enter() Peter Zijlstra
2018-09-07 13:41 ` Steven Rostedt
2018-09-07 13:45 ` Peter Zijlstra
2018-09-07 13:55 ` Steven Rostedt [this message]
2018-09-07 14:01 ` Steven Rostedt
2018-09-07 14:03 ` Peter Zijlstra
2018-09-07 14:52 ` Sergey Senozhatsky
2018-09-07 14:02 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907095533.5b5febc2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®