[PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock

[PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock

[Zhaoxiong Yuan]

idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary 
to call spin_lock_irqsave.
Signed-off-by: Zhaoxiong Yuan <yuanzhx326@gmail.com>
---
 drivers/dma/idma64.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index 1fbf9cb..5b9c156 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -142,9 +142,8 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
 {
 	struct idma64_chan *idma64c = &idma64->chan[c];
 	struct idma64_desc *desc;
-	unsigned long flags;
 
-	spin_lock_irqsave(&idma64c->vchan.lock, flags);
+	spin_lock(&idma64c->vchan.lock);
 	desc = idma64c->desc;
 	if (desc) {
 		if (status_err & (1 << c)) {
@@ -161,7 +160,7 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
 		if (idma64c->desc == NULL || desc->status == DMA_ERROR)
 			idma64_stop_transfer(idma64c);
 	}
-	spin_unlock_irqrestore(&idma64c->vchan.lock, flags);
+	spin_unlock(&idma64c->vchan.lock);
 }
 
 static irqreturn_t idma64_irq(int irq, void *dev)
-- 
1.9.1

Re: [PATCH] dma: idma64: replace spin_lock_irqsave with spin_lock

[Vinod]

On 08-09-18, 06:02, Zhaoxiong Yuan wrote:
> idma64_chan_irq() is invoked in hardirq handle function, it is unnecessary 
> to call spin_lock_irqsave.

Please add a line after log and s-o-b

I have applied after doing above and fixing subsystem tag (dmaengine)
-- 
~Vinod