* [PATCH] RDMA/hns: Fix an error code in hns_roce_v2_init_eq_table()
@ 2018-09-10 8:35 Dan Carpenter
2018-09-11 16:03 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-09-10 8:35 UTC (permalink / raw)
To: Lijun Ou
Cc: Wei Hu(Xavier),
Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel,
kernel-janitors
The error code isn't set on this path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 0218c0f8c2a7..b84bfa48371d 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -5125,6 +5125,7 @@ static int hns_roce_v2_init_eq_table(struct hns_roce_dev *hr_dev)
create_singlethread_workqueue("hns_roce_irq_workqueue");
if (!hr_dev->irq_workq) {
dev_err(dev, "Create irq workqueue failed!\n");
+ ret = -ENOMEM;
goto err_request_irq_fail;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA/hns: Fix an error code in hns_roce_v2_init_eq_table()
2018-09-10 8:35 [PATCH] RDMA/hns: Fix an error code in hns_roce_v2_init_eq_table() Dan Carpenter
@ 2018-09-11 16:03 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2018-09-11 16:03 UTC (permalink / raw)
To: Dan Carpenter
Cc: Lijun Ou, Wei Hu(Xavier),
Doug Ledford, linux-rdma, linux-kernel, kernel-janitors
On Mon, Sep 10, 2018 at 11:35:11AM +0300, Dan Carpenter wrote:
> The error code isn't set on this path.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-11 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 8:35 [PATCH] RDMA/hns: Fix an error code in hns_roce_v2_init_eq_table() Dan Carpenter
2018-09-11 16:03 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®