* [PATCH] ocfs2/dlm: Remove unnecessary parentheses
@ 2018-09-11 21:34 Nathan Chancellor
2018-09-11 21:38 ` Nick Desaulniers
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2018-09-11 21:34 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker
Cc: ocfs2-devel, linux-kernel, Nick Desaulniers, Nathan Chancellor
Clang warns when more than one set of parentheses is used for a
single conditional statement:
fs/ocfs2/dlm/dlmthread.c:534:18: warning: equality comparison with extraneous
parentheses [-Wparentheses-equality]
if ((res->owner == dlm->node_num)) {
~~~~~~~~~~~^~~~~~~~~~~~~~~~
fs/ocfs2/dlm/dlmthread.c:534:18: note: remove extraneous parentheses around the
comparison to silence this warning
if ((res->owner == dlm->node_num)) {
~ ^ ~
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
fs/ocfs2/dlm/dlmthread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
index 838a06d4066a..074d5de17bb2 100644
--- a/fs/ocfs2/dlm/dlmthread.c
+++ b/fs/ocfs2/dlm/dlmthread.c
@@ -531,7 +531,7 @@ void __dlm_dirty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
assert_spin_locked(&res->spinlock);
/* don't shuffle secondary queues */
- if ((res->owner == dlm->node_num)) {
+ if (res->owner == dlm->node_num) {
if (res->state & (DLM_LOCK_RES_MIGRATING |
DLM_LOCK_RES_BLOCK_DIRTY))
return;
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ocfs2/dlm: Remove unnecessary parentheses
2018-09-11 21:34 [PATCH] ocfs2/dlm: Remove unnecessary parentheses Nathan Chancellor
@ 2018-09-11 21:38 ` Nick Desaulniers
0 siblings, 0 replies; 2+ messages in thread
From: Nick Desaulniers @ 2018-09-11 21:38 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: mark, jlbec, ocfs2-devel, LKML
On Tue, Sep 11, 2018 at 2:35 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when more than one set of parentheses is used for a
> single conditional statement:
>
> fs/ocfs2/dlm/dlmthread.c:534:18: warning: equality comparison with extraneous
> parentheses [-Wparentheses-equality]
> if ((res->owner == dlm->node_num)) {
> ~~~~~~~~~~~^~~~~~~~~~~~~~~~
> fs/ocfs2/dlm/dlmthread.c:534:18: note: remove extraneous parentheses around the
> comparison to silence this warning
> if ((res->owner == dlm->node_num)) {
> ~ ^ ~
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> fs/ocfs2/dlm/dlmthread.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c
> index 838a06d4066a..074d5de17bb2 100644
> --- a/fs/ocfs2/dlm/dlmthread.c
> +++ b/fs/ocfs2/dlm/dlmthread.c
> @@ -531,7 +531,7 @@ void __dlm_dirty_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res)
> assert_spin_locked(&res->spinlock);
>
> /* don't shuffle secondary queues */
> - if ((res->owner == dlm->node_num)) {
> + if (res->owner == dlm->node_num) {
> if (res->state & (DLM_LOCK_RES_MIGRATING |
> DLM_LOCK_RES_BLOCK_DIRTY))
> return;
> --
> 2.18.0
>
Thanks for the simple fix, Nathan.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-11 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 21:34 [PATCH] ocfs2/dlm: Remove unnecessary parentheses Nathan Chancellor
2018-09-11 21:38 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®