* [PATCH] clk: mvebu: ap806: Remove superfluous of_clk_add_provider
@ 2018-09-12 15:35 Gregory CLEMENT
2018-10-01 22:13 ` Stephen Boyd
0 siblings, 1 reply; 2+ messages in thread
From: Gregory CLEMENT @ 2018-09-12 15:35 UTC (permalink / raw)
To: Stephen Boyd, Mike Turquette, linux-clk, linux-kernel
Cc: Thomas Petazzoni, linux-arm-kernel, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Gregory CLEMENT, Antoine Tenart,
Miquèl Raynal, Maxime Chevallier
While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to
system controller driver"), of_clk_add_provider was added wheres it was
already present in the probe function.
This extraneous call is harmless but not useful so remove it.
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
drivers/clk/mvebu/ap806-system-controller.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/mvebu/ap806-system-controller.c b/drivers/clk/mvebu/ap806-system-controller.c
index 9fbec3eb725f..ea54a874bbda 100644
--- a/drivers/clk/mvebu/ap806-system-controller.c
+++ b/drivers/clk/mvebu/ap806-system-controller.c
@@ -153,7 +153,6 @@ static int ap806_syscon_common_probe(struct platform_device *pdev,
goto fail4;
}
- of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
ret = of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
if (ret)
goto fail_clk_add;
--
2.18.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: mvebu: ap806: Remove superfluous of_clk_add_provider
2018-09-12 15:35 [PATCH] clk: mvebu: ap806: Remove superfluous of_clk_add_provider Gregory CLEMENT
@ 2018-10-01 22:13 ` Stephen Boyd
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2018-10-01 22:13 UTC (permalink / raw)
To: Gregory CLEMENT, Mike Turquette, Stephen Boyd, linux-clk, linux-kernel
Cc: Thomas Petazzoni, linux-arm-kernel, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Gregory CLEMENT, Antoine Tenart,
Miquèl Raynal, Maxime Chevallier
Quoting Gregory CLEMENT (2018-09-12 08:35:49)
> While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to
> system controller driver"), of_clk_add_provider was added wheres it was
> already present in the probe function.
>
> This extraneous call is harmless but not useful so remove it.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-01 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 15:35 [PATCH] clk: mvebu: ap806: Remove superfluous of_clk_add_provider Gregory CLEMENT
2018-10-01 22:13 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome