* [PATCH] net/usb: cancel pending work when unbinding smsc75xx
@ 2018-09-28 23:04 Yu Zhao
2018-10-04 20:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yu Zhao @ 2018-09-28 23:04 UTC (permalink / raw)
To: David S. Miller, Steve Glendinning
Cc: netdev, linux-usb, linux-kernel, Yu Zhao
Cancel pending work before freeing smsc75xx private data structure
during binding. This fixes the following crash in the driver:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
IP: mutex_lock+0x2b/0x3f
<snipped>
Workqueue: events smsc75xx_deferred_multicast_write [smsc75xx]
task: ffff8caa83e85700 task.stack: ffff948b80518000
RIP: 0010:mutex_lock+0x2b/0x3f
<snipped>
Call Trace:
smsc75xx_deferred_multicast_write+0x40/0x1af [smsc75xx]
process_one_work+0x18d/0x2fc
worker_thread+0x1a2/0x269
? pr_cont_work+0x58/0x58
kthread+0xfa/0x10a
? pr_cont_work+0x58/0x58
? rcu_read_unlock_sched_notrace+0x48/0x48
ret_from_fork+0x22/0x40
Signed-off-by: Yu Zhao <yuzhao@google.com>
---
drivers/net/usb/smsc75xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c
index 05553d252446..b64b1ee56d2d 100644
--- a/drivers/net/usb/smsc75xx.c
+++ b/drivers/net/usb/smsc75xx.c
@@ -1517,6 +1517,7 @@ static void smsc75xx_unbind(struct usbnet *dev, struct usb_interface *intf)
{
struct smsc75xx_priv *pdata = (struct smsc75xx_priv *)(dev->data[0]);
if (pdata) {
+ cancel_work_sync(&pdata->set_multicast);
netif_dbg(dev, ifdown, dev->net, "free pdata\n");
kfree(pdata);
pdata = NULL;
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/usb: cancel pending work when unbinding smsc75xx
2018-09-28 23:04 [PATCH] net/usb: cancel pending work when unbinding smsc75xx Yu Zhao
@ 2018-10-04 20:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-04 20:52 UTC (permalink / raw)
To: yuzhao; +Cc: steve.glendinning, netdev, linux-usb, linux-kernel
From: Yu Zhao <yuzhao@google.com>
Date: Fri, 28 Sep 2018 17:04:30 -0600
> Cancel pending work before freeing smsc75xx private data structure
> during binding. This fixes the following crash in the driver:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
> IP: mutex_lock+0x2b/0x3f
> <snipped>
> Workqueue: events smsc75xx_deferred_multicast_write [smsc75xx]
> task: ffff8caa83e85700 task.stack: ffff948b80518000
> RIP: 0010:mutex_lock+0x2b/0x3f
> <snipped>
> Call Trace:
> smsc75xx_deferred_multicast_write+0x40/0x1af [smsc75xx]
> process_one_work+0x18d/0x2fc
> worker_thread+0x1a2/0x269
> ? pr_cont_work+0x58/0x58
> kthread+0xfa/0x10a
> ? pr_cont_work+0x58/0x58
> ? rcu_read_unlock_sched_notrace+0x48/0x48
> ret_from_fork+0x22/0x40
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-04 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 23:04 [PATCH] net/usb: cancel pending work when unbinding smsc75xx Yu Zhao
2018-10-04 20:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®