From: Lance Roy <ldr709@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>,
Lance Roy <ldr709@gmail.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
"David S. Miller" <davem@davemloft.net>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: [PATCH 04/16] i40e: Replace spin_is_locked() with lockdep
Date: Tue, 2 Oct 2018 22:38:50 -0700 [thread overview]
Message-ID: <20181003053902.6910-5-ldr709@gmail.com> (raw)
In-Reply-To: <20181003053902.6910-1-ldr709@gmail.com>
lockdep_assert_held() is better suited to checking locking requirements,
since it won't get confused when someone else holds the lock. This is
also a step towards possibly removing spin_is_locked().
Signed-off-by: Lance Roy <ldr709@gmail.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: intel-wired-lan@lists.osuosl.org
Cc: <netdev@vger.kernel.org>
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index ac685ad4d877..8ce3471723d3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -1489,8 +1489,7 @@ int i40e_del_mac_filter(struct i40e_vsi *vsi, const u8 *macaddr)
bool found = false;
int bkt;
- WARN(!spin_is_locked(&vsi->mac_filter_hash_lock),
- "Missing mac_filter_hash_lock\n");
+ lockdep_assert_held(&vsi->mac_filter_hash_lock);
hash_for_each_safe(vsi->mac_filter_hash, bkt, h, f, hlist) {
if (ether_addr_equal(macaddr, f->macaddr)) {
__i40e_del_filter(vsi, f);
--
2.19.0
next prev parent reply other threads:[~2018-10-03 5:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 5:38 Using lockdep instead of spin_is_locked() Lance Roy
2018-10-03 5:38 ` [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep Lance Roy
2018-10-03 16:00 ` Bjorn Helgaas
2018-10-04 6:50 ` Lance Roy
2018-10-03 5:38 ` [PATCH 02/16] hv_balloon: " Lance Roy
2018-10-03 13:20 ` Vitaly Kuznetsov
2018-10-03 5:38 ` [PATCH 03/16] sgi-xp: " Lance Roy
2018-10-03 5:38 ` Lance Roy [this message]
2018-10-04 18:56 ` [Intel-wired-lan] [PATCH 04/16] i40e: " Bowers, AndrewX
2018-10-03 5:38 ` [PATCH 05/16] igbvf: " Lance Roy
2018-10-13 0:11 ` Brown, Aaron F
2018-10-03 5:38 ` [PATCH 06/16] sfc: " Lance Roy
2018-10-03 5:38 ` [PATCH 07/16] smsc: " Lance Roy
2018-10-03 5:38 ` [PATCH 08/16] wireless: " Lance Roy
2018-10-03 9:06 ` Kalle Valo
2018-10-04 6:57 ` Lance Roy
2018-10-04 10:05 ` Kalle Valo
2018-10-05 8:35 ` [PATCH 08/16] zd1211rw: " Kalle Valo
2018-10-03 5:38 ` [PATCH 09/16] scsi: " Lance Roy
2018-10-03 13:53 ` Bart Van Assche
2018-10-11 2:37 ` Martin K. Petersen
2018-10-03 5:38 ` [PATCH 10/16] userfaultfd: " Lance Roy
2018-10-03 5:38 ` [PATCH 11/16] futex: " Lance Roy
2018-10-09 11:21 ` [tip:locking/core] " tip-bot for Lance Roy
2018-10-03 5:38 ` [PATCH 12/16] locking/mutex: " Lance Roy
2018-10-09 12:18 ` Will Deacon
2018-10-09 13:36 ` Paul E. McKenney
2018-10-03 5:38 ` [PATCH 13/16] mm: " Lance Roy
2018-10-03 7:37 ` Vlastimil Babka
2018-10-03 5:39 ` [PATCH 14/16] netfilter: " Lance Roy
2018-10-03 8:29 ` Jozsef Kadlecsik
2018-10-03 5:39 ` [PATCH 15/16] apparmor: " Lance Roy
2018-10-03 5:56 ` John Johansen
2018-10-03 5:39 ` [PATCH 16/16] KVM: arm/arm64: vgic: " Lance Roy
2018-11-02 18:45 ` Christoffer Dall
2018-11-02 19:42 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003053902.6910-5-ldr709@gmail.com \
--to=ldr709@gmail.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome