From: Mark Brown <broonie@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "festevam@gmail.com" <festevam@gmail.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
Andy Duan <fugang.duan@nxp.com>,
"anders.roxell@linaro.org" <anders.roxell@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"john.stultz@linaro.org" <john.stultz@linaro.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators
Date: Wed, 3 Oct 2018 13:10:02 +0100 [thread overview]
Message-ID: <20181003121002.GA7132@sirena.org.uk> (raw)
In-Reply-To: <28e88d54f6503cf1be577eb1872cdf2c50d7dfa3.camel@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 674 bytes --]
On Tue, Oct 02, 2018 at 01:42:38PM +0000, Leonard Crestez wrote:
> This turns the phy off and on again instead of leaving it up from uboot
> and it doesn't work for some reason. However looking at
> reg_fixed_voltage_probe introducing an edge seems to be intentional for
> regulators which are not marked with "enabled-at-boot". Right?
No, that's definitely not desired. We don't want to change the state of
the regulator at all if we can avoid it unless the user explicitly asked
for it.
> It's possible that you exposed an imx board-specific bug: maybe power
> cycling the phy after uboot needs some missing fixup?
It'd probably also be good to sort this out though.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-10-03 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 20:43 Linus Walleij
2018-10-01 21:56 ` John Stultz
2018-10-02 13:42 ` Leonard Crestez
2018-10-03 12:10 ` Mark Brown [this message]
2018-10-03 18:08 ` Leonard Crestez
2018-10-04 7:19 ` Linus Walleij
2018-10-04 10:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003121002.GA7132@sirena.org.uk \
--to=broonie@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=john.stultz@linaro.org \
--cc=leonard.crestez@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®