mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Duan <fugang.duan@nxp.com>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"anders.roxell@linaro.org" <anders.roxell@linaro.org>,
	"john.stultz@linaro.org" <john.stultz@linaro.org>
Subject: Re: [PATCH] regulator: fixed: Default enable high on DT regulators
Date: Thu, 4 Oct 2018 11:20:12 +0100	[thread overview]
Message-ID: <20181004102012.GB6412@sirena.org.uk> (raw)
In-Reply-To: <c2ace38e09344d325271498fe8133c888470b5f6.camel@nxp.com>

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

On Wed, Oct 03, 2018 at 06:08:09PM +0000, Leonard Crestez wrote:
> On Wed, 2018-10-03 at 13:10 +0100, Mark Brown wrote:

> > No, that's definitely not desired.  We don't want to change the state of
> > the regulator at all if we can avoid it unless the user explicitly asked
> > for it.

> That also makes sense, for a top level perspective. But
> reg_fixed_voltage_probe contains the following snippet:

...

> In theory it might be possible to request the GPIO while asking to keep
> the value from the bootloader? Maybe I'm confused but I don't see an
> easy way to do this through the GPIO api; functions for requesting in
> output mode all seem to also ask for the initial value.

There isn't one.  You're not supposed to read back an output GPIO at all
unfortunately, it makes this sort of handover stuff a problem.

> GPIOD_ASIS looks close but it doesn't even adjust the direction.

That's new - it's probably closest to what we want but we need to be
able to read back the state as well and will want to make it output if
it isn't already.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2018-10-04 10:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01 20:43 Linus Walleij
2018-10-01 21:56 ` John Stultz
2018-10-02 13:42 ` Leonard Crestez
2018-10-03 12:10   ` Mark Brown
2018-10-03 18:08     ` Leonard Crestez
2018-10-04  7:19       ` Linus Walleij
2018-10-04 10:20       ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181004102012.GB6412@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=john.stultz@linaro.org \
    --cc=leonard.crestez@nxp.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®