From: Peter Zijlstra <peterz@infradead.org>
To: 'Sebastian Andrzej Siewior' <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
David Laight <David.Laight@ACULAB.COM>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all()
Date: Wed, 17 Oct 2018 18:22:53 +0200 [thread overview]
Message-ID: <20181017162253.GO3121@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181017160050.rw6tl2dzqiozbq3m@linutronix.de>
On Wed, Oct 17, 2018 at 06:00:51PM +0200, 'Sebastian Andrzej Siewior' wrote:
> On 2018-10-17 17:47:07 [+0200], Peter Zijlstra wrote:
> > > > Ideally we'd never ever merge anything that only does local invalidates,
> > > > on a global address space, that's just broken.
> > >
> > > A little bit late to lament about that.
> >
> > For this, yes :/ But for future stuff we should really not allow such
> > things anymore.
>
> so we stay as is?
Well, we can do that preempt kludge you propose to shut up the warning I
suppose.
But a kludge it is. That code really wants a global invalidate, but we
cannot (not without massive surgery in any case).
next prev parent reply other threads:[~2018-10-17 16:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 20:25 [0/3] A few 32bit x86 fixes Sebastian Andrzej Siewior
2018-10-16 20:25 ` [PATCH 1/3] x86/mm/pat: Disable preemption around __flush_tlb_all() Sebastian Andrzej Siewior
2018-10-16 21:25 ` Andy Lutomirski
2018-10-16 21:38 ` Sebastian Andrzej Siewior
2018-10-16 23:28 ` Andy Lutomirski
2018-10-17 10:34 ` [PATCH 1/3 v2] " Sebastian Andrzej Siewior
2018-10-29 18:10 ` [tip:x86/urgent] " tip-bot for Sebastian Andrzej Siewior
2018-11-05 21:56 ` Dan Williams
2018-10-17 9:54 ` [PATCH 1/3] " David Laight
2018-10-17 10:39 ` 'Sebastian Andrzej Siewior'
2018-10-17 11:45 ` David Laight
2018-10-17 12:00 ` 'Sebastian Andrzej Siewior'
2018-10-17 11:11 ` Peter Zijlstra
2018-10-17 11:17 ` Thomas Gleixner
2018-10-17 15:47 ` Peter Zijlstra
2018-10-17 15:55 ` Thomas Gleixner
2018-10-17 16:00 ` 'Sebastian Andrzej Siewior'
2018-10-17 16:22 ` Peter Zijlstra [this message]
2018-10-16 20:25 ` [PATCH 2/3] x86/fpu: Remove second definition of fpu in __fpu__restore_sig() Sebastian Andrzej Siewior
2018-10-16 21:26 ` Andy Lutomirski
2018-10-17 9:09 ` [tip:x86/urgent] " tip-bot for Sebastian Andrzej Siewior
2018-10-18 6:22 ` tip-bot for Sebastian Andrzej Siewior
2018-10-16 20:25 ` [PATCH 3/3] x86/fpu: Save FPU registers on context switch if there is a FPU Sebastian Andrzej Siewior
2018-10-16 23:00 ` Andy Lutomirski
2018-10-17 9:10 ` [tip:x86/urgent] x86/fpu: Fix i486 + no387 boot crash by only saving FPU registers on context switch if there is an FPU tip-bot for Sebastian Andrzej Siewior
2018-10-18 6:22 ` tip-bot for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181017162253.GO3121@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Laight@ACULAB.COM \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome